Menu
▾
▴
[Zookeeper-developer] [ zookeeper-Patches-1958274 ] Removed unused variables from FastLeaderElection
|
From: SourceForge.net <no...@so...> - 2008-05-07 02:54:11
|
Patches item #1958274, was opened at 2008-05-05 21:16 Message generated for change (Comment added) made by mahadevkonar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: server Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: fpj (fpj) Assigned to: Mahadev Konar (mahadevkonar) Summary: Removed unused variables from FastLeaderElection Initial Comment: Removed unused variables from FastLeaderElection. -Flavio ---------------------------------------------------------------------- >Comment By: Mahadev Konar (mahadevkonar) Date: 2008-05-07 02:54 Message: Logged In: YES user_id=1926680 Originator: NO is this related to https://sourceforge.net/tracker/index.php?func=detail&aid=1956801&group_id=209147&atid=1008546 ? from the description it looks like they are the same... ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 18:34 Message: Logged In: YES user_id=12853 Originator: NO There is an issue with this patch: 1) line 248 has "rand" variable which the patch removes initialization, but not the field also: 2) cleanup imports (remove random and zoolog) 3) there are more unused vars which could be removed, lines; 152, 250, 269 Btw - if you are using eclipse you can get findbugs at: http://findbugs.sourceforge.net/manual/eclipse.html ---------------------------------------------------------------------- Comment By: Patrick Hunt (phunt) Date: 2008-05-06 17:40 Message: Logged In: YES user_id=12853 Originator: NO The assignee is responsible for closing (committing) this patch (see ZooKeeperPatches on wiki) -- this includes getting additional review if necessary. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1958274&group_id=209147 |
