[Zookeeper-developer] [ zookeeper-Patches-1872448 ] Replace select() with poll() in the I/O thread

[SourceForge.net <no...@so...>]

Patches item #1872448, was opened at 2008-01-15 15:24
Message generated for change (Comment added) made by breed
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1872448&group_id=209147

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: c client
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andrew Kornev (akornev)
Assigned to: Nobody/Anonymous (nobody)
Summary: Replace select() with poll() in the I/O thread

Initial Comment:
Use poll() in the event loop to overcome select() limitation of max 1024 file descriptors. 
Also, the patch includes:
- removed unused declarations from zookeeper.h/.c
- implemented zoo_set_log_stream() public API to make it possible for applications to define their own stream for the zookeeper library logs
- minor fixes to the unit tests

----------------------------------------------------------------------

>Comment By: Benjamin Reed (breed)
Date: 2008-01-15 19:02

Message:
Logged In: YES 
user_id=154690
Originator: NO

Looks good. The only problem I see is that you are not checking the return
code from poll.

----------------------------------------------------------------------

Comment By: Benjamin Reed (breed)
Date: 2008-01-15 19:02

Message:
Logged In: YES 
user_id=154690
Originator: NO

+1 make it happen

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1008546&aid=1872448&group_id=209147