ZNC - Advanced IRC Bouncer / Patches / #20 WritePidFile and DeletePidFile should use helper function

WritePidFile and DeletePidFile should use helper function

#20 WritePidFile and DeletePidFile should use helper function

Status: closed-fixed

Owner: Psychon

Labels: None

Priority: 5

Updated: 2010-04-24

Created: 2010-04-23

Creator: Reed Loden

Private: No

From http://en.znc.in/wiki/User:Psychon/ToDo, implement #10 -- "WritePidFile and DeletePidFile should use some common code to get the path for the pid file (copy & paste is evil :P) ".

Discussion

Reed Loden - 2010-04-23

v1 patch

znc-2991284-v1.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Psychon - 2010-04-23

Uhm, not going to commit this.
Here's a hint: When you call new, it usually makes sense to call delete later on.

And another hint: Don't code when tired, I usually write stupid bugs when I do that. ;)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Psychon - 2010-04-23

Oh, also it could make sense to make InitPidFile() protected/private since it's not really meant to be used by others. But that's pretty much a matter of taste...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Reed Loden - 2010-04-24

v2 patch

znc-2991284-v2.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Psychon - 2010-04-24

assigned_to: nobody --> psychon

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Psychon - 2010-04-24

r1929, thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

WritePidFile and DeletePidFile should use helper function

Group

Searches

Help

#20 WritePidFile and DeletePidFile should use helper function

Discussion