Menu
▾
▴
[ZNC-Users] [ znc-Bugs-1593342 ] IPv6 support broken
|
From: SourceForge.net <no...@so...> - 2011-05-14 23:59:40
|
Bugs item #1593342, was opened at 2006-11-09 12:06 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=672821&aid=1593342&group_id=115828 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Engine Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Bjoern Boschman (jes-o-mat) Assigned to: Psychon (psychon) Summary: IPv6 support broken Initial Comment: Hi, I'm using CVS HEAD from Thu Nov 9 12:50:15 CET 2006. My ${HOME}/.znc/configs/znc.conf includes: Listen6 = +31338 LoadModule = webadmin +8080 When I start znc a web-listener is created on 0.0.0.0:8080 (no-ipv6) Also no bouncer listener is created at all. znc was compiled with --enable-ipv6 If more input is neccessary I can provide it. I can also offer an shell-account on a host which has IPv6 connectivity. Cheers Bjoern ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2011-05-14 23:59 Message: Index.. Awful :) ---------------------------------------------------------------------- Comment By: Psychon (psychon) Date: 2006-11-29 13:42 Message: Logged In: YES user_id=1654410 Originator: NO https is http + ssl. If the ssl handshake fails it just resets the connection. That's default ssl behavior and the only way out of that is using TLS which isnt used widely, isnt used by znc and afaik does interfer with openssl. At least Csocket doesnt support TLS. Correct me if im wrong ;) ---------------------------------------------------------------------- Comment By: Jesus Christ (jesusch) Date: 2006-11-28 21:26 Message: Logged In: YES user_id=371384 Originator: NO The patches are working. Thnx for work work!! I'm not sure if I shall open up a new bugID for this: If I'm accessing the webadmin via http (not https) only a TCP-RST is send out. A protocol redirection should be made. ---------------------------------------------------------------------- Comment By: Psychon (psychon) Date: 2006-11-28 20:03 Message: Logged In: YES user_id=1654410 Originator: NO Im a developer an official znc developer since yesterday, before i only created patches and because there were many of them i had to use that svn repo and feeded the patches to prozac. We (crox^^) are / is currently working on getting all or the most important patches into sf.net cvs, then we will see whats next... Switching to subversion is a nice idea, i never used cvs.. But whats with the patches? Do they work for you as they do for me or did i break something? ;) ---------------------------------------------------------------------- Comment By: Jesus Christ (jesusch) Date: 2006-11-28 18:20 Message: Logged In: YES user_id=371384 Originator: NO Why don't you stick using the sf.net CVS or switch to sf.net Subversion? ---------------------------------------------------------------------- Comment By: Psychon (psychon) Date: 2006-11-28 16:16 Message: Logged In: YES user_id=1654410 Originator: NO Yeah they come from an subversion repo :) If it helps you, you can try this version: (I like viewvc...) http://svn.kuja.in/viewvc.cgi/znc/branches/psychon/modules/webadmin.cpp?r1=840&r2=866&view=patch http://svn.kuja.in/viewvc.cgi/znc/branches/psychon/znc.h?r1=840&r2=865&view=patch I guess it will take some time before they are in the cvs repo... ---------------------------------------------------------------------- Comment By: Bjoern Boschman (jes-o-mat) Date: 2006-11-28 12:51 Message: Logged In: YES user_id=1641276 Originator: YES I'll wait until the changes find their way into CVS before closing this bug. Applying the patches using patch -p0 did not work for me. Maybe because they seem to come out of an subversion repo. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-11-26 11:37 Message: Logged In: NO and here is the patch for webadmin which is also on its way to cvs. if the first argument to webadmin is -ipv4 or -ipv6 it uses that one, else it tells you to add one of them. ;) The output looks like this: [ ] Loading Global Module [webadmin]... [ ** ] Please use -ipv4 or -ipv6 as first argument to webadmin [ ok ] But there is nothing i can do about this for know, at least webadmin works with ipv6 ;) Thanks for the bug report and i guess this one can be closed now. Index: modules/webadmin.cpp =================================================================== --- modules/webadmin.cpp (Revision 860) +++ modules/webadmin.cpp (Arbeitskopie) @@ -115,10 +115,21 @@ return true; } - virtual bool OnLoad(const CString& sArgs) { + virtual bool OnLoad(const CString& csArgs) { bool bSSL = false; + bool bIPv6 = false; CString sPort; + CString sArgs = csArgs.Token(1, true); + if(csArgs.Token(0).CaseCmp("-IPV4") != 0) { + if(csArgs.Token(0).CaseCmp("-IPV6") == 0) { + bIPv6 = true; + } else { + CUtils::PrintMessage("Please use -ipv4 or -ipv6 as first argument to webadmin", true); + sArgs = csArgs; + } + } + if (sArgs.find(" ") != CString::npos) { m_sListenHost = sArgs.Token(0); sPort = sArgs.Token(1); @@ -146,7 +157,7 @@ } #endif - return m_pManager->ListenHost(m_uPort, "WebAdmin::Listener", m_sListenHost, bSSL, SOMAXCONN, pListenSock); + return m_pManager->ListenHost(m_uPort, "WebAdmin::Listener", m_sListenHost, bSSL, SOMAXCONN, pListenSock, 0, bIPv6); } void AddSock(CWebAdminSock* pSock) { ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-11-26 11:12 Message: Logged In: NO webadmin does never use ipv6 -> bug, im working on it Listen6 had a bug, here is a patch to fix it. The patch is already on its way to cvs. Index: znc.h =================================================================== --- znc.h (Revision 864) +++ znc.h (Arbeitskopie) -219,7 +219,7 @@ } #endif - return CZNC::Get().GetManager().ListenHost(m_uPort, "_LISTENER", m_sBindHost, bSSL, SOMAXCONN, pClient, m_bIPV6); + return CZNC::Get().GetManager().ListenHost(m_uPort, "_LISTENER", m_sBindHost, bSSL, SOMAXCONN, pClient, 0, m_bIPV6); } private: protected: ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=672821&aid=1593342&group_id=115828 |