Menu

#12 always false statement

1.0
closed
None
2016-01-05
2016-01-02
No

dmatrix.c
int look_ahead_test(unsigned char source[], int sourcelen, int position, int current_mode, int gs1)
{
...
/ step (p) /
/ edifact /
done = 0;
if((source[sp] >= ' ') && (source[sp] <= '^')) { edf_count += (3.0f / 4.0f); done = 1; }
if(source[sp] > 127) { edf_count += (17.0f / 4.0f); done = 1; }
if(done = 0) edf_count += (13.0f / 4.0f); / <-- ALWAYS FALSE /

    Should be
    if (done == 0) ...

Discussion

  • Harald Oehlmann

    Harald Oehlmann - 2016-01-04

    Corrected in [779894], thank you, Harald

     

    Related

    Commit: [779894]

  • Harald Oehlmann

    Harald Oehlmann - 2016-01-04
    • status: open --> accepted
    • assigned_to: Harald Oehlmann
     
  • Harald Oehlmann

    Harald Oehlmann - 2016-01-05
    • status: accepted --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB