#11 endless loop in to_latin1

[Mark J. Olesen]

png.c

If source[i] >= 128 && source[i] != 0xC2 && source[i] != 0xC3 then
'i' will never get incremented resulting in an endless loop.

693 void to_latin1(unsigned char source[], unsigned char preprocessed[])
...
701 while (i < input_length) {
702 if(source[i] < 128) {
...
706 } else {
707 if(source[i] == 0xC2) {
...
711 }
712 if(source[i] == 0xC3) {
...
716 }
717 }
718 }

[Harald Oehlmann]

Thank you, right.
Does the fix at commit [2a1d6b] work for you ?
https://sourceforge.net/p/zint/code/commit_browser

Thank you,
Harald

[Mark J. Olesen]

Howdy,

Thanks for the quick turn around. There is no longer a hang condition
(endless loop).

Regards,
Mark

On Mon, Jan 4, 2016 at 10:15 AM, Harald Oehlmann oehhar@users.sf.net
wrote:

Thank you, right.
Does the fix at commit [2a1d6b]
http://sourceforge.net/p/zint/code/ci/2a1d6b8e48906ea14e8ba34f122048f7b5244434/
work for you ?
https://sourceforge.net/p/zint/code/commit_browser

Thank you,
Harald

---

• [tickets:#11] http://sourceforge.net/p/zint/tickets/11/ endless loop
  in to_latin1*

Status: open
Milestone: 1.0
Created: Thu Dec 31, 2015 06:28 AM UTC by Mark J. Olesen
Last Updated: Thu Dec 31, 2015 06:28 AM UTC
Owner: nobody

png.c

If source[i] >= 128 && source[i] != 0xC2 && source[i] != 0xC3 then
'i' will never get incremented resulting in an endless loop.

693 void to_latin1(unsigned char source[], unsigned char preprocessed[])
...
701 while (i < input_length) {
702 if(source[i] < 128) {
...
706 } else {
707 if(source[i] == 0xC2) {
...
711 }
712 if(source[i] == 0xC3) {
...
716 }
717 }
718 }

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/zint/tickets/11/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Harald Oehlmann]

Closed as fix was verified.
We could also place a replacement character for unprintables to show that there is something...
This is mainly helpful for control characters...