#41 Possible bug in SendMailSenderFix

[Maxxer]

Created a new mail, this is the result in WBXML:

25/06/2014 11:14:56 [27138] [DEBUG] [riccardo.sama@domain.it] Zimbra->SendMailSenderFix(): START SendMailSenderFix { $deviceFrom = ; }
25/06/2014 11:14:56 [27138] [DEBUG] [riccardo.sama@domain.it] Zimbra->SendMailSenderFix(): No/Empty From: header - Setting name from Identities using device login (email address)
25/06/2014 11:14:56 [27138] [DEBUG] [riccardo.sama@domain.it] Zimbra->SendMailSenderFix(): Using account default _sendAsName
25/06/2014 11:14:56 [27138] [DEBUG] [riccardo.sama@domain.it] Zimbra->SendMailSenderFix(): END SendMailSenderFix { "Riccardo Samà" <Riccardo Samà> }

Proposed fix attached

[LiverpoolFCfan]

I don't think that is a valid fix. The problem is not the username part but rather the email address part. Does the logfile show an _sendasemail ?

It should be the email address within the < > brackets not the user's name.

Can you send a wbxml level debug log of a full SendMail request please

[Maxxer]

With that patch applied I fixed the issue. Do you still want the logs?

[Maxxer]

I don't think that is a valid fix. The problem is not the username part
but rather the email address part. Does the logfile show an _sendasemail ?

No, no messages for _sendasemail, just the _sendAsName that I posted.

It should be the email address within the < > brackets not the user's
name.

Isn't it that way?
$value = '"' . $this->_identities[$this->_username] .'" <'.
$this->_username .'>';
$this->_username is the email address, like in your patch.

Phone is an Android 4.4.4 (CyanogenMod nightly)

[LiverpoolFCfan]

If you have Release 60, this should fix the issue.

At line 10099

                    if (isset($this->_identities[$this->_username])) {
                        ZLog::Write(LOGLEVEL_DEBUG, 'Zimbra->SendMailSenderFix(): ' . 'No/Empty From: header - Setting name from Identities using device login (email address)' );
                        $value = $this->_identities[$this->_username];
                        $found = true;
                    } 

Change the middle line to $value = $this->_username; as follows

                    if (isset($this->_identities[$this->_username])) {
                        ZLog::Write(LOGLEVEL_DEBUG, 'Zimbra->SendMailSenderFix(): ' . 'No/Empty From: header - Setting name from Identities using device login (email address)' );
                        $value = $this->_username;
                        $found = true;
                    } 

Let me know if this resolves it.

By the way, what device type is it? It is not sending a From: header

[LiverpoolFCfan]

Messages are in jumbled order - so not sure what fix you applied.

Can you confirm if you made the change I recommended ? And, if not, can you please try it instead of the one you had listed, please.

Thanks

[LiverpoolFCfan]

I have looked back at your patch suggestion again, and you are correct in the first instance - you do have $this->_username in there.

However, you are assigning the "User Name" at the same time. This is actually handled in the next code block - allowing for the user to have specified an OverrideSendAsName. Your patch would break that ability.

In any event, thanks for the hint on the source of the problem. It made finding it very quick.

[LiverpoolFCfan]

Fix will be released in Release 61.

Code is in the repository as 60.1 in the interim.

[LiverpoolFCfan]

Fix will be in Release 61. Checked into code repository as 60.1 in the meantime.

Closing ticket.