|
From: Thomas L. <ta...@gm...> - 2010-02-20 18:18:07
|
On 13 February 2010 15:08, Thomas Leonard <ta...@gm...> wrote:
> On 12 February 2010 00:23, Frank Richter <fra...@gm...> wrote:
>> On 10.02.2010 15:03, Bastian Eicher wrote:
[...]
>>> The ZeroInstall code contains a bunch of .startswith('/') checks to
>>> differentiate local paths from URLs.
>>> Unfortunately this is no good on Windows. Here an absolute file-system path
>>> is signified by a single letter followed by colon.
>>> Currently the code will fail to locate the local "ZeroInstall-GUI.xml" feed
>>> for this reason.
>>
>> The "local path" test should probably be wrapped into a function.
>
> I think we should use a separate attribute for paths. e.g.
>
> <implementation local-dir='.'>
>
> or something like that.
>
> The id (if not given) could be auto-generated as "file:." in this
> case, for places where we really do need an ID (e.g. to identify which
> implementation you marked as "buggy"), but we could use
> Implementation.local_path whenever we really want a pathname. This
> would avoid needing magic strings anywhere.
As a first step towards this, Implementation.local_path now gives the
pathname for a local implementation, or None for anything else
(including cached items).
--
Dr Thomas Leonard ROX desktop / Zero Install
GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA
|