Discovered and Reported by Oliver Emery (thrymgjol)
#2. In Add/Edit Character dialog, allow use of IME in traditional input field
#2. In the Add Entry or Edit Entry dialog, even with the ime on, the traditional textbox does not have an ime attached, so it types normal text when you have autofill off.
Originally reported on: http://www.chinese-forums.com/index.php?/topic/44618-zdt-102-released/?p=344725
Confirmed. I tried it with IME on (CTRL-I or Edit -> IME Mod), and we cannot type any Chinese in the Tradional field of the 'Add Entry' dialog. To be complete, tested with and without Traditional Mode (CTRL-T or Edit -> Tradional Mode); both cases the problem occurs. Will create a bug for this in ZDT.
Bug still assigned to Kaya, as Oliver is still awaiting approval. Oliver could you post here the lines of corrected code that you talked about?
for both EditEntryWizardPage.java and AddEntryWizardPage.java:
replace
private IMEConnector imeConnector;
with
private IMEConnector imeConnectorS;
private IMEConnector imeConnectorT;
And replace all instances of
imeConnector
withimeConnectorS
Then attach an
ImeConnector
tomTraditionalText
by replacingmTraditionalText = new Text(entryInfoComposite, SWT.BORDER);
gd = new GridData();
gd.grabExcessHorizontalSpace = true;
gd.horizontalAlignment = SWT.FILL;
gd.verticalIndent = VERTICAL_INDENT;
mTraditionalText.setLayoutData(gd);
with
mTraditionalText = new Text(entryInfoComposite, SWT.BORDER);
gd = new GridData();
gd.grabExcessHorizontalSpace = true;
gd.horizontalAlignment = SWT.FILL;
gd.verticalIndent = VERTICAL_INDENT;
mTraditionalText.setLayoutData(gd);
imeConnectorT = new IMEConnector();
imeConnectorT.setTraditionalMode(true);
imeConnectorT.register(new IMETextWidget(mTraditionalText));
I couln't make you owner of this bug when it was created since you were not in the system yet. Now you are.
Kaya often sent me the changed .jar file(s), so I could test the change(s). Is that a good idea? Tx.
Fixed and uploaded.
Retested - fix pending. Steps:
Turn on Ime Mode (Edit -> IME Mode or CTRL-I)
In the Add Entry or Edit Entry dialog, the traditional textbox shows still normal text (no option to select Chinese character as in the Simplified field). Behavior is the same as originally reported (Wed Aug 13, 2014 05:02 PM UTC)
* To be sure, tried with both Autofill on and off.
Were the (new) EditEntryWizardPage.java and the (new) AddEntryWizardPage.java both included in zdt.jar or 'Flashcard Plug-in version 1.0.3.jar'? In which final jar are these two .java files compiled? Or did the upload this fix somehow fail?
If they were included, then the fix didn't seem to help. Any thoughts?
Tested with: rebuild (by kaya) "Flashcard Plug-in version 1.0.3" and "zdt.jar" - replaced these files in respectively 'zdt\plugins\net.sourceforge.zdt.core_1.0.2' and 'zdt\'. (supposedly up to build 1241, but cannot verify in .JAR file).
As far as I know, I've only uploaded the source code. Testing it directly
from eclipse, my fixes seem to work. I am unsure about compiling, so that
may be the reason.
On Mon, Jan 26, 2015, 2:09 AM Michael van den Berg mvdberg112@users.sf.net
wrote:
Related
Bugs:
#157Retested in v1.0.3 beta (v1.03v2). Confirmed Fixed.
Choose Edit -> IME to turn on ZDT's build-in IME.
Open a category by double clicking.
In the category editor, press CTRL-N for a new entry.
Type for example 'jian' in the traditional field - 間 appars as first option.
* Select 1. The rest fill sin automatically.
(cedict was theactive dictionary during these steps)
Tried also for simplified field to be sure:
Type for example 'jian' in the simplified field - 间 appears as first option.
Select 1. The rest fills in automatically.
IME works both in the Simplified field and the Traditional field now. Fixed.