Re[2]: [zd1211-devs] Another kernel oops fix (timer related)

[Roman K <rom...@ma...>]

> [ restoring CC to zd1211-devs ]
> 
> On Thu, Mar 24, 2005 at 03:08:19PM +0100, Svetoslav Slavtchev wrote:
> > Mike wrote:
> > > +  unsigned long flags;
> > > +
> > > +  save_flags(flags);
> > > +  cli();
> > 
> > aren't those pretty broken in 2.6
> > IIRC cli() was removed at least 6 months ago

2.6, 2.4 or 2.2 doesn't matter. spin_lock_irqsave ()/spin_unlock_irqrestore()
should be use instead if we want to be smp compatible. 

> 
> Oh, oops :).  I didn't know that, as we're still developing on 2.4.
> Thanks for pointing it out.
> 
> If you or someone else that knows about the 2.6 changes wouldn't mind
> writing some #ifdefs or finding some other appropriate solution, that
> would be best for me, otherwise I can try and come up with it myself
> though as I have no convenient way of testing it I don't promise it will
> work.
> 
> Mike
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
> Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
> Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
> by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click
> _______________________________________________
> Zd1211-devs mailing list
> Zd1...@li...
> https://lists.sourceforge.net/lists/listinfo/zd1211-devs
>