Re: [zd1211-devs] ZD1211
Status: Beta
Brought to you by:
mayne
From: Dan S. <dds...@ie...> - 2005-03-07 19:24:21
|
Hi all, I have to agree this is much better than #ifdefs. when this is eventually merged into the mainstream kernel, this design will be much easier to merge than an #ifdef'ed design. On Sun, 6 Mar 2005, Markus Karg wrote: >Dmitriy, > >Since Kernels 2.4 and 2.6 have quite different interfaces we need to fulfil, >Arno and I want to remove the Kernel-specifics from the rest of the code: > >API-LAYER 2.4 (= Implementation of API 2.4) will be one file. >API-LAYER 2.6 (= Implementation of API 2.6) will be another file. >SPI-LAYER (= ZyDAS-spceifics) will be the rest. > >Do you see any problems here? Arno only knows 2.6, but you are 2.4 specialist. >As we have seen, your contribution separates both Kernels by a lot of >#ifdefs, what makes the code complex to read. > >The benefits will be: > >- Better to read >- Better to maintain >- MAKEFILE can decide what API-Layer to fulfil (instead of each file including >a lot of #ifdef) > >Markus > > >------------------------------------------------------- >SF email is sponsored by - The IT Product Guide >Read honest & candid reviews on hundreds of IT Products from real users. >Discover which products truly live up to the hype. Start reading now. >http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >_______________________________________________ >Zd1211-devs mailing list >Zd1...@li... >https://lists.sourceforge.net/lists/listinfo/zd1211-devs > -- Dan Streetman dds...@ie... --------------------- 186,272 miles per second: It isn't just a good idea, it's the law! |