Menu ▾ ▴

#16 Fix --help behaviour

closed
Jon Nangle
None
5
2006-09-11
2006-01-24
Ed Avis
No

--help should print a usage message and exit
successfully. This is even checked by the test suite,
but currently yasql does the wrong thing.

On line 234 of yasql.in change to

usage(0) if $opt_help;

Discussion

  • Jon Nangle

    Jon Nangle - 2006-09-11

    Logged In: YES
    user_id=982254

    Applied, thanks.

     

  • Jon Nangle

    Jon Nangle - 2006-09-11
    • assigned_to: nobody --> jpnangle
    • status: open --> closed
     

  • Kozman Bálint

    Kozman Bálint - 2006-09-20

    Logged In: YES
    user_id=1209168

    Well, invoking usage(0) will result in going on to ask for
    credentials which is undesired when asking for the help
    screen. I guess it just should exit quietly after printing
    help text.

     

  • Jon Nangle

    Jon Nangle - 2006-09-20

    Logged In: YES
    user_id=982254

    Yep, I added that to the patch (its in rev 3 in svn :)

     

Log in to post a comment.