Menu

#30 Make _extractCorePluginInfo accept Unicode filenames

Next Minor Release
closed
nobody
None
1
2015-05-08
2015-04-07
Otto
No

Hi!

I've created a PR for a small issue we ran into.

Not sure what the development process is, I sort of used the Github way of contributing (fork, raise PR), and hope this works for you.

PR: https://sourceforge.net/p/yapsy/code/merge-requests/1/

Discussion

  • Thibauld Nion

    Thibauld Nion - 2015-04-18
    • status: open --> accepted
     
  • Thibauld Nion

    Thibauld Nion - 2015-04-18

    Thanks for reporting this bug and sorry for that.

    I appreciate also that you proposed a pull request (I do accept and merge them) even though in this precise case, I'm going to reject it and replace it with a commit of my own.

    No ofense intended and the reason for that is that the change you propose is ok for python2 but would break python3 compatibility and since a few months the default branch of yapsy supports both. And there was also no need to add a new test data file as there are already plenty in the test/plugins folder.

    The good news is: with the small compatibility utils (compat.py) used here we have a simple way to do that (using basestring).

     
  • Thibauld Nion

    Thibauld Nion - 2015-04-18
    • status: accepted --> pending
     
  • Thibauld Nion

    Thibauld Nion - 2015-05-08
    • status: pending --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB