Menu ▾ ▴

#19 Plugin detection doesn't follow symlinks

Next Minor Release
closed
nobody
None
2
2014-06-07
2014-04-18
Thibauld Nion
No

From https://github.com/getnikola/nikola/issues/1234:

If you have plugins/foo -> /bar/foo it's not recognized as a plugin. Is probably a yapsy problem

This is indeed because PluginFileLocator.locatePlugins() uses walk without > following symlinks.

Roberto Alsina

Discussion

  • Thibauld Nion

    Thibauld Nion - 2014-04-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,7 @@
 From https://github.com/getnikola/nikola/issues/1234:

 > If you have plugins/foo -> /bar/foo it's not recognized as a plugin. Is probably a yapsy problem
-> Roberto Alsina

 > This is indeed because PluginFileLocator.locatePlugins() uses walk without > following symlinks.
+
+> Roberto Alsina
     

  • Thibauld Nion

    Thibauld Nion - 2014-04-18
    • summary: Plugin detectio doesn't follow symlinks --> Plugin detection doesn't follow symlinks
     

  • Thibauld Nion

    Thibauld Nion - 2014-05-31

    apparently the bug is triggered by symlinked directories that are below the directory given as the search path and the plugin directory.

    If only the plugin's directory is a symlink then no bug. And no bug either if the plugin info file is a symlink.

    So in the provided sample, assuming that foo is a plugin directory (ie with the plugin class defined in foo/__init__.py) then the bug would appear if plugins is a symlinked directory with plugins -> bar.

    Anyway this was the occasion to add some more tests on plugin locations and the bug is aobut to be fixed.

     

    Last edit: Thibauld Nion 2014-06-07

  • Thibauld Nion

    Thibauld Nion - 2014-06-07

    This is fixed in v1.10.423

     

  • Thibauld Nion

    Thibauld Nion - 2014-06-07
    • status: open --> closed
     

Anonymous
Anonymous

Add attachments
Cancel