Maybe no longer required, since parser now parses contiguous sequences of any length.
If still required, add some test cases with a different endianness.
YAT versions 1.99.70 and 1.99.80 used to take the endianness into account when encoding and decoding multi-byte encoded characters. However, it was always done, but of course e.g. UTF-8 is independent on endianness. The endianness would only have to be applied single multi-byte values, not multi-byte values split into multiple fragments. However, a .NET 'Encoding' object does not tell whether the encoding is potentially endianness capable or not. Thus, it was decided to again remove the character encoding endianness awareness.
Info message added to 'AdvancedTerminalSettings':
The endianness is currently fixed to 'Big-Endian (Network, Motorola)'. It was used by former versions of YAT but is currently not used anymore. Still, the setting is kept for future enhancements as documented in bug #343.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Already started completely removing from code, but somehow hesitated because endianness might be required to properly encode Unicode notation "\U+20AC" or "\U(20AC)". But that's neither the case, as the parser rather uses the configured encoding.
Thus, endianness completely removed from code. Still open:
Parser warning on e.g. \d(1000) behavior described further above.
Last edit: Maettu 2022-05-17
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Still needed, fixed.
YAT versions 1.99.70 and 1.99.80 used to take the endianness into account when encoding and decoding multi-byte encoded characters. However, it was always done, but of course e.g. UTF-8 is independent on endianness. The endianness would only have to be applied single multi-byte values, not multi-byte values split into multiple fragments. However, a .NET 'Encoding' object does not tell whether the encoding is potentially endianness capable or not. Thus, it was decided to again remove the character encoding endianness awareness.
Info message added to 'AdvancedTerminalSettings':
The endianness is currently fixed to 'Big-Endian (Network, Motorola)'. It was used by former versions of YAT but is currently not used anymore. Still, the setting is kept for future enhancements as documented in bug #343.
Inputs and considerations:
Depending on input and requests from others, Endianness will again be needed or can be removed.
Opinion SSt: Can be removed.
Last edit: Maettu 2022-04-29
Already started completely removing from code, but somehow hesitated because endianness might be required to properly encode Unicode notation "\U+20AC" or "\U(20AC)". But that's neither the case, as the parser rather uses the configured encoding.
Thus, endianness completely removed from code. Still open:
Last edit: Maettu 2022-05-17
Endianess restored from SVN revision #4093 as it is potentially needed for appending CRC.