Re: [xwax-devel] 45 RPM Patch
Brought to you by:
hills
From: Mark H. <ma...@po...> - 2010-08-07 20:51:54
|
On Mon, 2 Aug 2010, Mat?j Laitl wrote: > Mark, have you looked at the patch? What do you think about it? I've looked at both patches. Thanks to both of you! Particularly the attention to detail in keeping the spinner correct. You both make a minor mistake by correcting the speed before it is sent to the pitch filter (modifying dt before pitch_dt_observation). It is important that the correction happens after the filter, otherwise scratching will be smoothed differently at different RPMs. I didn't test this though, I suspect it's very minor (scratching 'feels' different at 45 RPM anyway). I wanted to take the best of both, which meant keeping the flexibility internally but also making it easy to set 33.33333 RPM! :-) I'll follow up this email with some revised patches, any comments welcome. -- Mark |