(xslide) Re: xslide Patch #813124: Add msxsl.exe support in xsl-process.el

[Ville <sc...@xe...>]

On Sat, 2003-11-08 at 04:39, Glen Peterson wrote:

> https://sourceforge.net/tracker/index.php?func=detail&aid=813124&group_id=22964&atid=377145
> 
> He deleted and replaced the following code with something that works on
> msxml but he *may* have broken some other processors in the process.

Yes, it is possible that this breaks something.

> I'm not sure how I would go about regression testing this because I
> don't know which processors use this code.  Do some of the processors
> that have their own specific code also use this "generic" code?

I don't know.

> Also, I'm unclear about how the user selects which processor they want
> to use.  Xt comes up by default.  If I want to use java apache xalan,
> what would you expect me to do?

The way I do is to invoke xsl-process, hit enter a couple of times to
accept the filenames, and then in the "Process command:" prompt hit
up-arrow until the one I prefer is there.  The order where the command
lines appear can be modified by customizing xsl-process-command.

> Do you have some time to review his patch and/or answer my questions,
> and/or add comments or patches to the code to answer these questions?  I
> will not merge Doug's patch until I get this figured out.  Anyone else
> want to shed light on the subject?

I took a look at the patch, some notes:
- Uses windows linebreaks (they show up as ^M here)
- For multiline regexps, I'd recommend taking a look how the jd.xslt 
  regexp is done instead of relying on the linebreaks.

While at it, I fixed some of the regexps so that they work here using
xsltproc and  Xalan from Java 1.4.2.  Patch attached (taken against
XEmacs CVS but I believe it should apply to vanilla xslide too).