Hi there,
This is my first attempt at a patch, so please be
gentle! I'm not sure if my changes will be accepted by
the developers, but I thought I'd post my work here in
case it is of use to some.
This patch includes two little adjustments and is
against files from CVS from the 10th of this month.
Firstly, our team finds it necessary to be able to get
lists of contacts by industry, so I've added the
Industries drop down menu and the ability to search on
this criteria to contacts/some.php.
I've also been really interested in the changes made by
dbaudone which allow activities to be created in bulk.
However, for some reason there is no button to do this
for a list of contacts... I've added this button to the
page. So you can now, for example, search for a
selection of contacts, snail mail them and then do a
bulk activity process to add activities to everyone
you've mailed!
I should add that to make this work I had to remove a
few lines from bulkactivity/bulkassignment.php. The
code relating to Custom Labels threw up errors for some
reason. I've attached this patch too.
I'd appreciate any feedback, and hope this is of some use.
With kind regards and thanks to all the developers!
Add search for contacts by industry and add bulk activity
Logged In: YES
user_id=204919
First of all, *thank you* for patching against near-current
CVS! It can be extremely difficult to assess and apply
changes that aren't against current code. And a huge *thank
you* also for providing patch files. Many people just give
us the entire modified file, so we need to diff and compare
them by hand.
As for your patches, they look like they'll be easy enough
to apply and test.
You received errors on the custom1-4 fields for one of two
reasons, I haven't examined specifically why yet. One
possible reson is that the patches from dbaudone included
some code that we rejected, to make the custom1-4 fields
into drop-downs. the other reason is that I'm not sure if
the fields are named the same in the contacts and companies
tables. I'll look into this when I test your patch.
Thank you for contributing to XRMS!
Regards,
- Brian