#118 Company multiple category selection and enhanced campaigns
Thi is a second set of enhancements complementary to
those already subdued with "bulk activity/assigment,
new home page and many enhancements".
A brief explanation of the changes apported:
Admin
1) Changed company types query selection
2) In one_email_template.php changed string 'title' in
'Email Template Title'
3) Changed delete salutation query: now it works
4) Added custom fields widget content in index.php
Campaigns
1) Calendar javascript modified to work with every
language and system
2) Added company sidebar to show company linked to a
campaign
3) Added possibility to insert activity from company
sidebar
4) Added possibility to have cases linked to a campaign
need to add a filed to cases table:
ALTER TABLE `cases` ADD `campaign_id` INT( 11 ) NOT
NULL ;
5) in one.php
- required bulk-activity-widget
- included companies sidebar
- included cases sidebar
- changed default clomuns and extra_where query
passed to GetActivitiesWidget
- notes sidebar not shown
- added bulkAssigment feature to companies sidebar
6) in some.php
- added bulk activity feature
- added not status check box
- deleted mail merge feature
Include/classes/pager
1) in Array_Sorter.php changed sortit($remap=true) to
sortit($remap=false)
in order to alphabetically sort companies names in
campaign/company_sidebar.php
cases
1) in edit.php: modified calendar script to make it
working with every language and system
2) in new-2.php
- added opportunity_id and campaign_id variables
- assign 1 to contact_id if not set (contact_id = 1
means no contact linked)
3) in new.php
- added opportunity_id and campaign_id variables
- assign 1 to company_id if not set (company_id = 1
means no company linked)
- get contact menu only if is set contact_id (to
avoid it for cases linked to campaign)
- get division menu only if is set contact_id (to
avoid it for cases linked to campaign)
- modified function restrictByCaseType() to work for
cases linked to campaign or opportunity
4) in one.php
- add campaign_id field and selection query for
cases linked to a campaign
- show contact info only when contact_id = 1
- show company info only when company_id = 1
- show campaign info only when cases are linked to a
campaign
5) modified cases sidebar for deal with cases linked to
campaigns and opportunities
6) in some.php:
- added return_url in bulkEmail()
Companies
- added link to campaign
- added company type field
- added query for not category condition
- added possibility to define search condition based on
multiple category selection in advanced search
1) in edit.php
- added company_type_id field
- added company_type menu
- added custom fields menus
- added campaigns menu
2) in new-2.php
- added campaign_id
- added company_type_id
- commented company_code default setting
3) in new.php
- added company_type_id field
- added company_type menu
- added custom fields menus
- added campaigns menu
4) in one.php
- added company_type
- added cell phone display in contacts info
- added return_url in mailmerge call
- changed mailto href to contacts email
5) in some.php
- added function createCategoryList()
- added query for not category search condition
- added definition of search condition based on
multiple category selection in advanced search
- enhanced basic search layout (added more selectin
fields like crm_status ...)
- added company_type field
- added search for campaign link in advanced search
- changed addr.address_body in addr.province
- modified "like" search condition for address
fields (city, line1 ...), profile
- commented preg_replace in phone sqls
- added "null" search condition for fax, url
- changed customs fields search conditions
- added custom fields menus
- reduced width style for menus displaying
- changed primary_address to province in default_columns
- added bulkAssigment and bulkActivity buttons
- delete SnailMail button
- added return url to bulkEmail function
Contacts
1) in new.php
- eliminated outset style from country menu
2) in one.php
- changed mailto to avoid activity insertion
- commented out notes sidebar
3) in some.php
- defined return_url
- added company category field selection
- added not checkbox for fields: user, title,
description, contact category, company category
- added null selection for email
- added bulkActivity insertion bar
- added Phone and Cell Phone to selectable column layout
- changed default columns setting
- changed new GUP_Pager call to display contact
email href link
- eliminated SnailMail button
- added return_url to bulkEmail call
Logged In: YES
user_id=204919
I'm sorely tempted to reject this entire patch set. It
removes at least as much core functionality as it adds.
Removing creation of activities for emails will *not* get
into the core.
Removing phone formatting will *not* get into the core. Why
don't you spend some time and implement Right-to-Left
formatting of phone number rather than breaking working
functionality? described here:
https://sourceforge.net/pm/task.php?func=detailtask&project_task_id=126544&group_id=88850&group_project_id=32473
I really want the campaign enhancements, but it might be
simply too much work to avoid hundreds of little changes
that remove working features.
Logged In: YES
user_id=204919
I think changing the default behavior of the Pager
Array_Sorter.php is dangerous. I don't understand why you
wouldn't use an ORDER BY in your query, or set the default
sort column of the Pager before rendering it in
casmpaigns/company-siderbar.php. Changing the default
behavior of every Pager in the system seems guaranteed to
have unwanted consequences.
Logged In: YES
user_id=1203017
First of all thanks for your attention to my work.
I really understand that in my proposal there could be some
changes that are functional only to my environment.
Certainly among them there are:
- Removing creation of activities for emails
- Removing phone formatting
For the latter I hope you find a better general solution
(one further idea could be to make the phone formatting
optional).
So there could be some other arguable point in my code.
Feel free to reject or improve them.
Anyway I hope you could find the main issues that could be
adopted in the XRMS core.
Among them:
- Enancements in campaing (that coupled with BulkAssigment
and BulkActivity in my previous patch set, makes XRMS more
powerful)
- Enhancements in company advanced search with multiple
category selection (and 'not' category selection)
Regarding your question about the Pager Array_Sorter.php the
reason for this change was that it is the only way I found
to show companies alpabetically sorted in the company
sidebar added to campaign's one.php.
My be a better way to code it in company-sidebar.php under
campaigns or elsewhere, leaving Array_Sorter.php unchanged.
However I've not found (with my use of XRMS) any case where
this have caused some misbehaviour.
As you see I've well delimited all my changes (db: begin -
db: end) and the most of them are thought to add features.
If you want I can clean my code where you think are removed
working features.