[xpad-devel] Window options

[Sham C. <el...@sh...>]

G'day.

Here's a patch I've been meaning to submit for a while now.. It adds the 
following options to the prefs dialog box:
- pads show up in taskbar
- pads show up in pager
- pad windows (above / same level as / below) other windows

The 'window level' code in particular might need some cleanup if it is 
to be included.. but it seems to work quite well as it is. ;)

The patch also includes a fix for a pad height saving bug.. I noticed 
that every time I closed and restarted xpad, my pads would gradually 
reduce in height. I traced it down to these 2 lines in save_info 
(xpad-pad.c):

	if (GTK_WIDGET_VISIBLE (pad->priv->toolbar))
		height -= pad->priv->toolbar_height;

The height reduction happens when the pad toolbars are set to be always 
visible (no autohide) - I haven't tested with hidden toolbars, but I 
guess pads with hidden toolbars wouldn't be affected.. The problem is 
that, if toolbars are always visible, save_info saves the height of the 
pad window minus the toolbar height - when load_info is then called, 
this reduced height is read and the entire pad window (including the 
toolbar) is resized to this reduced height. Commenting out these 2 lines 
fixes the problem.

An alternative fix (which I haven't tested) could be to move the 
"xpad_pad_notify_has_toolbar (pad);" call at the end of xpad_pad_init 
(or maybe simply repeat it?) after the gtk_window_resize call in load_info..

Cheers
-S

p.s. The diff is against the xpad 2.8 Debian (sid) source package