#164 Color boxes loading pictures from home directory

[H:S]

Hi,
I just found a strange and funny little bug.

For no apparent reason, my tool-bar one day became "oversized" and re-installing Xournal or purging the configuration file did not help. After a while I noticed that it is probably caused by one of the boxes for selecting colors. It became very large, but what was even stranger -- it was no longer square. Then it finally dawned on me: I had a 640x480 px sized "black.png" file in my home directory, completely black and suspiciously matching the new size of the color box.

To test my theory, I replaced contents of the file -- you can see the result on the attached screenshot. :) Only .png files seem to be loaded this way and it seems to be looking for the files only in the current working directory (which happens to be ~/ when launched from XFCE4 app menu).

(Also, as you may notice, some of the toolbar icons are not very well suited for dark system themes.. ;) )

Thanks,
Martin

[Denis Auroux]

Oops. The idea is that, if xournal is not installed into the system tree
(make install) but run in the compilation directory ("just want to test
it before I actually install this thing"), or if the installation
directory is setup after compilation time (Windows binary package that
can just be placed anywhere on disk and run in place), then we still
want the graphical elements for the toolbar to get loaded properly. So:
the plan was to look in the directory containing the executable file,
and nearby locations (pixmaps and ../pixmaps relative paths), in case
the files can't be found in the location where they should be.

Except: (1) the paths were actually searched in reverse order of what I
had intended, so that files near the xournal executable take precedence
over those in the installation directory; and (2) if the xournal
executable is in the path and you just run xournal from a terminal, then
the search happens near the current working directory (e.g. $HOME)
rather than near the directory containing the xournal executable.

So: easy fix without recompiling: modify the launcher in the XFCE4 app
menu so that it runs "/usr/bin/xournal" (or whatever is appropriate)
rather than just "xournal". (then it'll still look in /usr/bin/pixmaps
and /usr/pixmaps but none of these should be problematic).

Better fix: grab the latest CVS or GIT code snapshot, where I should
have fixed this issue. (If you do this, please confirm that it fixes the
problem.)

Denis

[H:S]

Confirmed, the issue is now fixed in the latest GIT version. :)

Thank you,
Martin

[Denis Auroux]

Release 0.4.8.2016 is up to date with cvs/git repositories, and should include a fix for this bug. Please reopen if problems persist with 0.4.8.2016 or with the current cvs/git code.