I have modified the 2.3.0 system module templates, correcting some of the xHTML for validation purposes -
system_comments_flat.html
system_comments_nest.html
system_comments_thread.html
system_imagemanager2.html
system_imagemanager.html
system_redirect.html
system_siteclosed.html
system_userinfo.html
blocks/
system_block_comments.html
system_block_newusers.html
system_block_siteinfo.html
system_block_topusers.html
Logged In: YES
user_id=1095348
Originator: NO
Nice work! I attached a diff file to make it easier to review.
The only tiny detail that imo should be changed is the white space in system_imagemanager.html line #51 and system_imagemanager2.html line #32.
Other than that for me it's fine. If Skalpa (the release manager) agrees then it will be in the next release.
Thanks for helping to improve XOOPS :-)
File Added: patch-1712443-diff.zip
Logged In: YES
user_id=1817010
Originator: NO
Files where revised and one line in one file fixed "system_userinfo.html"
zip file rebuild on http://templates.pierdtimp.ro/xoops230templatechanges.zip
can one add this file to the tracker please
Thank you
updated to include a-ph3x's change + a few more
Logged In: YES
user_id=773222
Originator: YES
File Added: xoops230system.zip
Logged In: YES
user_id=773222
Originator: YES
File Added: templates.diff
New diff file between patch and 2.0.17
Logged In: YES
user_id=1001493
Originator: NO
Next week
Logged In: YES
user_id=1001493
Originator: NO
OK, I'll take care of this one personally.
Logged In: YES
user_id=1817010
Originator: NO
now thats what i call good news :D
Logged In: YES
user_id=1730840
Originator: NO
good exemple --> system_block_siteinfo.html
<{foreach item=group from=$block.groups}> <{if $group.users}>-
<{$group.name}>
<{/if}>
<{/foreach}>
<{/if}><{foreach from=$group.users item=user}>-
<{$user.name}>
<{/foreach}>
<{$user.msglink}>
<{$block.recommendlink}>
or --> system_notification_select.html
<{$xoTheme->addStylesheet('modules/system/style.css')}>
<style type="text/css"> #notifform { display: none;} </style><script type="text/javascript">
function hideAll()
{
document.getElementById('notifform').style.display = 'none';
}
function showForm(obj)
{
obj.style.display = 'block';
}
</script>
<{if $xoops_notification.show}>
<form id="notifform" name="notification_select" action="<{$xoops_notification.target_page}>" method="post"><{$lang_notificationoptions}>
<{$lang_activenotifications}>
<input type="hidden" name="not_redirect" value="<{$xoops_notification.redirect_script}>"/> <{foreach name=outer item=category from=$xoops_notification.categories}> <{foreach name=inner item=event from=$category.events}> <{if $smarty.foreach.inner.first}> <{/if}> <{/foreach}> <{/foreach}><{/if}>
Logged In: YES
user_id=1730840
Originator: NO
And for system_userinfo.html (exemple version 2.0.1x) :
<{elseif $xoops_isadmin != false}>
<{/if}>
<{$user_ranktitle}>
<{$module.name}>
<{foreach item=result from=$module.results}> <{$result.title}>
<{/foreach}>(<{$result.time}>)
<{/foreach}> <{$module.showall_link}>