[Xoops-trackers] [ xoops-Bugs-3051852 ] Config options issue - possible during install/update module

[SourceForge.net <no...@so...>]

Bugs item #3051852, was opened at 2010-08-23 22:13
Message generated for change (Settings changed) made by trabis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=430840&aid=3051852&group_id=41586

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core -  Core
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: madreus (madreus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Config options issue - possible during install/update module

Initial Comment:
Example notification options. If the various options (defined in xoops_version.php) have the same title (defined in the language file), in the form of preferences is displayed only one of item.

This is a piece of code

foreach ($categories as $category) {
                $events =& notificationEvents ($category['name'], false, $module->getVar('mid'));
                foreach ($events as $event) {
                    if (!empty($event['invisible'])) {
                        continue;
                    }
                    $option_name = $category['title'] . ' : ' . $event['title'];
                    $option_value = $category['name'] . '-' . $event['name'];
                    $options[$option_name] = $option_value;
                }
            }

The key in $options array is $option_name. Therefore, two (or more) options can be merged into one if the titles of two (or more) different options will be translated exactly the same in the language file. The probability of such a mistake is much higher (many translators) rather than giving the same name by the developer in xoops_version.php

The code is in two files (main.php AND modulesadmin.php) in /modules/system/admin/modulesadmin/

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=430840&aid=3051852&group_id=41586