From: SourceForge.net <no...@so...> - 2008-01-29 02:30:08
|
Bugs item #1881197, was opened at 2008-01-28 10:17 Message generated for change (Comment added) made by phppp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=430840&aid=1881197&group_id=41586 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core - Core Group: XOOPS 2.0.x >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: CPK Smithies (cpks) Assigned to: Nobody/Anonymous (nobody) Summary: Silencing Javascript Diagnostics (2 of 2) Initial Comment: In the 2.0.18 release, include/xoops.js contains a function at line 45 openWithSelfMain(). The last parameter to the function, returnwindow, determines whether the function returns a window or null. Unfortunately, the Firefox developer diagnostics object to the following 3 lines at the end of the function (lines 51-3) (quote): if (returnwindow != null) { return new_window; } - with the warning: "Function does not always return a value". To silence this warning, without altering the functionality of openWithSelfMain(), the following single line can be substituted in place of lines 51-3: return (returnwindow != null ? new_window : void(0)); My thanks to the Xoops developer team for their sterling work! CPKS ---------------------------------------------------------------------- >Comment By: D.J. (phppp) Date: 2008-01-28 21:30 Message: Logged In: YES user_id=1001493 Originator: NO Fixed in Rev 1281 http://xoops.svn.sourceforge.net/viewvc/xoops?view=rev&revision=1281 ---------------------------------------------------------------------- Comment By: D.J. (phppp) Date: 2008-01-28 21:30 Message: Logged In: YES user_id=1001493 Originator: NO Fixed in SVN and waiting for review before merging to the trunk. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=430840&aid=1881197&group_id=41586 |