[XonX-Users] X11.app patch Revisited

[John D. P. <joh...@ma...>]

I've posted a few bugs with the patch against 6.8.2 on the patch  
page. Here they are again:

In .../apple/dri_glx.c, __driConfigOptions is declared as static,  
though in extras/Mesa/include/GL/internal/dri_interface.h it is not  
(its declared with extern, then used in .../glx/dri_glx.c). This  
causes the build on 6.8.2 to fail. :-!

In .../darwin/quartz/applewm.c, appleWMProcs is declared as static,  
though in .../darwin/quartz/applewmExt.h it it not. This causes the  
build to fail. :-!

I "fixed" both by commenting out static on that particular line. :-p

I have another problem that I'm not sure how to fix. In .../apple/ 
X11Application.m, `darwinSwapAltMeta' is used. This variable is  
defined in .../drwinKeyboard.c (note that's a .c file, not a .h  
file...?). I'm not sure what to include here to make this happy...  
Should I declare it again in X11Application.m? iDon't think so, b/c  
darwinKeyboard.c uses it...

in darwinKeyboard.c, darwinSwapAltMeta is declared `int  
darwinSwapAltMeta = 0;', and then checked at the end of the function  
`if (darwinSwapAltMeta)'. I'm guessing that this is supposed to pick  
up somewhere the setting! But, appearently it doesn't...? meThinks  
that X11Application.m is trying to set this very setting, but its not  
available. Did it used to be global? If I make it global, will Jesus  
hate me?

JP



--
"They [our enemies] never stop thinking about new ways to harm our  
country and our people, and neither do we. We must never stop  
thinking about how best to offend our country." - George W. Bush  
(August 5, 2004)