Menu

Roms Filter Patch

2002-09-13
2002-10-15
  • Francia Andrea

    Francia Andrea - 2002-09-13

    There is a patch for SearchFilter.java, it adds "Roms" filter. It's welcome?

    --- SearchFilter.java   Fri Sep 13 11:15:39 2002
    +++ SearchFilter.java-roms      Fri Sep 13 11:15:08 2002
    @@ -61,7 +61,7 @@
         public static final int MEDIA_DOCUMENTS = 5;

         public static final Object[] media = {
    -       "Anything", "Audio", "Video", "Images", "Software", "Documents"
    +        "Anything", "Audio", "Video", "Images", "Software", "Documents", "Roms"
         };

         /* these should be made configurable in the future, they are ordered
    @@ -87,10 +87,15 @@
            "html", "txt", "pdf", "lit", "ps", "dvi", "doc", "tex" , "zip"
         };

    +    public static final String[] roms = {
    +        "zip", "smc", "rom", "n64", "v64", "bin", "gba", "gb"
    +    };
    +
         public static final String[][] mediaTypes = {
    -       audio, video, images, software, documents
    +        audio, video, images, software, documents, roms
         };

    +
         //--- Data field(s) ---

         private Data data;

     
    • Yven Johannes Leist

      Hi Francia,
      first of all thanks for taking the time to write this patch and sorry for the belated reply!
      Now to the patch itself: shouldn't these extension be simply added to the software mediatype because these roms can be seen as some sort of software as well?
      (Actually the ideal solution would be to make the mediatypes configurable by the user...)

      cheers,
      Yven

      PS: actually we do not use this forum (thats also the main reason we never reacted to your patch) so I cross-posted this message to our development list (xnap-devel@lists.sf.net), so please continue any discussion there.

       

Log in to post a comment.