[xmp] module files broken between libxmp 4.3 and 4.4

[Ralf H. <ra...@bo...>]

Hi,

I have recently updated to version 4.4 and found some issued with a few
module files. I have bisected the problems to specific commits which
added some sanity checks, maybe those modules are actually broken, or
the sanity checks are too strict.

Anyway, the files played with libxmp 4.3 and you might want to take a look:

1. http://aminet.net/mods/med/Unknowncause1.lha
   bad commit: 56da12ab4ed839211ef56a9c94f6f6a7b8033d26
2. http://aminet.net/mods/chip/LexstacyTheme.lha
   bad commit: 3ea658ea893c294306c0071709f73547010ba444
3. mod.Cant_Get_Enough from http://aminet.net/mods/sets/Firsties.lha
   bad commit: 3ea658ea893c294306c0071709f73547010ba444

   Interestingly, this file https://modarchive.org/module.php?35098
   seems to be similar (same title, similar size), but it does not play
   at all, even with older libxmp version

4. http://www.antialias.se/chiptunes/xm/ZALZA%20-%20Tekilla%20groove.xm
   and
   http://www.antialias.se/chiptunes/xm/JUHO%20-%20Ihana%20paiva.xm
   bad commit: 41d149ae1ac4729b68c39ba6a2d9bf7eedf983e7

5. http://aminet.net/mods/pop/Crepequs.lha
   This one does not play even with old version starting at 2.4.0, but
   worked in xmp-2.3.2
   I can't bisect since the git repo seems to miss some files.

I don't know much about the actual formats to verify the sanity checks
so I hope you can take a look and fix those issues. If you need more
information or testing, I'm happy to help.

Best Regards,

Ralf

-- 
Ralf Hoffmann <ra...@bo...>
Homepage: http://www.boomerangsworld.de