From: Aaron V. <gru...@gm...> - 2011-09-17 02:09:22
|
Hi, I've been watching this list for a while, but this is my first contribution. I've uploaded two patches adding a bit of functionality to the objc compat-lib: 1) Implement java.lang.Iterable in xmlvm2objc http://xmlvm-reviews.appspot.com/163001/ 2) Implement CGContext.selectFont and CGContext.setTextPosition http://xmlvm-reviews.appspot.com/164001/ Comments appreciated. Thanks! --Aaron V. |
From: Arno P. <ar...@pu...> - 2011-09-17 06:59:26
|
first of all, thanks for your patch! Some quick comments: > 1) Implement java.lang.Iterable in xmlvm2objc > http://xmlvm-reviews.appspot.com/163001/ This is fine, not however, that with the C backend you won't need to implement anything from J2SE since we cross-compile Apache Harmony. > 2) Implement CGContext.selectFont and CGContext.setTextPosition > http://xmlvm-reviews.appspot.com/164001/ Can you please implement the same API for the C backend as well? (src/xmlvm2c/compat-lib/iphone) Thanks, Arno |
From: Markus H. <ma...@ti...> - 2011-09-17 10:31:14
|
If you commit the patch without a C implementation I can add the implementation in my CG* rewrite patch. Am 17.09.2011 um 08:59 schrieb Arno Puder: > > first of all, thanks for your patch! > > Some quick comments: > >> 1) Implement java.lang.Iterable in xmlvm2objc >> http://xmlvm-reviews.appspot.com/163001/ > > This is fine, not however, that with the C backend you won't need to > implement anything from J2SE since we cross-compile Apache Harmony. > >> 2) Implement CGContext.selectFont and CGContext.setTextPosition >> http://xmlvm-reviews.appspot.com/164001/ > > Can you please implement the same API for the C backend as well? > (src/xmlvm2c/compat-lib/iphone) > > Thanks, > Arno > > ------------------------------------------------------------------------------ > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > http://p.sf.net/sfu/rim-devcon-copy2 > _______________________________________________ > Xmlvm-developers mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xmlvm-developers |
From: Aaron V. <gru...@gm...> - 2011-09-17 17:50:10
|
> Can you please implement the same API for the C backend as well? > (src/xmlvm2c/compat-lib/iphone) I see in the 2c compat-lib, each method has an int id used in the reflection data and in method_dispatcher. Is it preferred to just add the new methods at the end, or to insert the new methods in a particular order (in the objc patch, I put them near similar functions), and then bump up the ids of all the methods below that? --Aaron On Fri, Sep 16, 2011 at 11:59 PM, Arno Puder <ar...@pu...> wrote: > > first of all, thanks for your patch! > > Some quick comments: > >> 1) Implement java.lang.Iterable in xmlvm2objc >> http://xmlvm-reviews.appspot.com/163001/ > > This is fine, not however, that with the C backend you won't need to > implement anything from J2SE since we cross-compile Apache Harmony. > >> 2) Implement CGContext.selectFont and CGContext.setTextPosition >> http://xmlvm-reviews.appspot.com/164001/ > > Can you please implement the same API for the C backend as well? > (src/xmlvm2c/compat-lib/iphone) > > Thanks, > Arno > > ------------------------------------------------------------------------------ > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > http://p.sf.net/sfu/rim-devcon-copy2 > _______________________________________________ > Xmlvm-developers mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xmlvm-developers > |
From: Arno P. <ar...@pu...> - 2011-09-17 17:58:55
|
actually, most of that code is generated. After you have added the Java methods, invoke "ant gen-c-wrappers" and the C files will be updated. You only should inject code between //BEGIN_WRAPPER and //END_WRAPPER markers. Take a look at the comments in org_xmlvm_iphone_NSObject.m Markus has offered to write the C wrappers for your methods so you are off the hook. :) Arno On 9/17/11 10:50 AM, Aaron VonderHaar wrote: >> Can you please implement the same API for the C backend as well? >> (src/xmlvm2c/compat-lib/iphone) > > I see in the 2c compat-lib, each method has an int id used in the > reflection data and in method_dispatcher. > > Is it preferred to just add the new methods at the end, or to insert > the new methods in a particular order (in the objc patch, I put them > near similar functions), and then bump up the ids of all the methods > below that? > > --Aaron > > On Fri, Sep 16, 2011 at 11:59 PM, Arno Puder<ar...@pu...> wrote: >> >> first of all, thanks for your patch! >> >> Some quick comments: >> >>> 1) Implement java.lang.Iterable in xmlvm2objc >>> http://xmlvm-reviews.appspot.com/163001/ >> >> This is fine, not however, that with the C backend you won't need to >> implement anything from J2SE since we cross-compile Apache Harmony. >> >>> 2) Implement CGContext.selectFont and CGContext.setTextPosition >>> http://xmlvm-reviews.appspot.com/164001/ >> >> Can you please implement the same API for the C backend as well? >> (src/xmlvm2c/compat-lib/iphone) >> >> Thanks, >> Arno >> >> ------------------------------------------------------------------------------ >> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA >> http://p.sf.net/sfu/rim-devcon-copy2 >> _______________________________________________ >> Xmlvm-developers mailing list >> Xml...@li... >> https://lists.sourceforge.net/lists/listinfo/xmlvm-developers >> |