Re: [xmlvm-users] pending patches

[Panayotis K. <pan...@pa...>]

On 18 Μαρ 2010, at 4:36 ΜΜ, Sascha Haeberling wrote:

> Panayotis,
>
> I just saw your giant patch. Do you think you can split it up into  
> smaller chunks? The bigger a patch gets, the harder it is for us to  
> review it and the longer it will take. A patch at that size is very  
> impractical to handle.
>
> If you could split it up into smaller chunks, that would help speed  
> up the process a lot.
>
> Thanks

Yes I know it's a monstrous patch, " I told you so" ;-)

The problem is that I did an overall change in the compatibility  
library, by defining a couple of useful macros (basically have a look  
at the end of xmlvm.h) which affect most (if not all) of org_xmlvm_*  
files. This has to do with my previous question "who owns a returned  
object", if you remember.
Along with this, there are many many additions to already defined  
files that merge with these changes. And of course new files that  
follow the same rules. And all this is mirrored in Java, with the new  
methods only as placeholders for the actual Obj-C calls ( in other  
words, it doesn't work in the emulator - yet).

Thus the only practical way to "split" this patch is only to give some  
files at a time (i.e today give all files that start with A, then of  
B, then of C etc :P ) but I don't know how this will help the  
reviewing process :)

As I said in previous posts, instead of sending a couple of files  
every six months, I prefer to give as much as I can now,  make now  
this library strong and useful and help it spread out, instead of  
thinking of timeframes and when ( or better "if") my contribution will  
expire.


PS: I practically didn't touch (yet) the java_* files and apply these  
rules, since there should have also a look what java actually does  
(i.e. some exceptions should be thrown).