Re: [xmlvm-users] java.awt.Color and family

[Sascha H. <sa...@xm...>]

Hi,
well 5600 LOC sounds much better. But again, it is quite big and I would
like you to give us feedback as early as possible. While we highly look
forward to your contribution, we should make sure you don't make major
changes that we might have disagreements on. We probably won't but as I
haven't seen your patch, I want to make sure no time is wasted. So try to
assemble a patch as soon as possible for us to reviews.

In general, the smaller a patch the better it is and the more effective it
is for us to review.

About the error: Make sure your patch is created from the correct root. The
root should be:
http://xmlvm.svn.sourceforge.net/svnroot/xmlvm/trunk/xmlvm/

So in your patch file, the paths should start with 'src/'. If you don't get
it to work, feel free to send the patch to my e-mail address and I will take
a look.

Thanks
// Sascha

PS: I am sure you read it, but just to remind you: Please make sure your
code is formatted according to our code guidelines and is well documented (
http://xmlvm.org/contribute/) This will help us maintain a good quality of
the code and will make it easier for us to review. Thanks!


2009/10/14 Panayotis Katsaloulis <pan...@pa...>

>
> On 14 Οκτ 2009, at 1:49 π.μ., Sascha Haeberling wrote:
>
> > Hi Panayotis,
> >
> > first of all, I think the earlier you have a patch that is
> > consistent and doesn't break anything, the better it is. If the
> > patch is too large it will take us too long to review it. So I think
> > it is your responsibility to try to break the patch down into
> > manageable chunks.
> >
> > 390.000 lines of code sounds strange to me. Does this include a
> > bunch of auto-generates empty stubs?
> >
> > // Sascha
>
> No, but it had some refactoring, since as I said I separated the view
> of the GUI elements from the model, and so the public methods (of the
> GUI elements again) are clear and reflect what they really support.
>  They are not really 390K of code, since diff puts some extra headers
> in the beginning and in the end.
> A typical
> diff -ruN  xmlvm xmlvm.patched  | grep '^\+' | wc
> gives ~5600 lines of code
>
> The changes now are in *so* many places that I don't think it's
> possible to make smaller patches. I can only break it into (e.g.)
> patches for obj-c support library and patches for xmlvm core itself.
> But I'm not sure if this will help at all :)
> I can not even distinguish the patches for the demos, since some of
> them depend on the support library
>
> PS: I tried to upload the patch to http://xmlvm-reviews.appspot.com/
> new but every time I select a file I get an error message saying
> Patch set contains no recognizable patches
>
>
> PS2: Is there already a tool to create auto-generated empty stubs?
> Because I am coding one right now, and if there is it will save my time.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> xmlvm-users mailing list
> xml...@li...
> https://lists.sourceforge.net/lists/listinfo/xmlvm-users
>