From: Sascha H. <sa...@xm...> - 2009-10-13 22:50:30
|
Hi Panayotis, first of all, I think the earlier you have a patch that is consistent and doesn't break anything, the better it is. If the patch is too large it will take us too long to review it. So I think it is your responsibility to try to break the patch down into manageable chunks. 390.000 lines of code sounds strange to me. Does this include a bunch of auto-generates empty stubs? // Sascha 2009/10/14 Panayotis Katsaloulis <pan...@pa...> > > On 14 Οκτ 2009, at 12:09 π.μ., Wolfgang Korn wrote: > > > I just committed a refactoring of the Objective C String class > > implementation. java.lang.String is now based on NSString while > > java.lang.StringBuffer is still based on NSMutableString. So Strings > > are immutable now as they are in Java. > > > > -- Wolfgang > > Nice! > > I was thinking that, since I do a lot of work on the library and on > the obj-c part, I am afraid that after some time without reviewing my > patches, it would be impossible to synchronize. > I have a few issues before I finish my part, but the work that I've > done is already a lot. Right now, all java-based things work, and some > native need to tweak them a bit more. > > Do you believe should i do a patch even at this time, and upload it to > the site? > There are a lot of changes and they will accumulate when time goes by. > I don't want to fork, I want to stay in your track. > > I think the best thing I could do is create a super-patch with all > changes (I think from version 536) and upload it there. > A diif with "diff -ruN" is more or less 390K !!! > What do you think? > > ( Right now I am writing a tool to automatically create skeleton files > from java files to objective-c files, so that creating the native part > from the java library to be as easy as possible) > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > xmlvm-users mailing list > xml...@li... > https://lists.sourceforge.net/lists/listinfo/xmlvm-users > |