Re: [Xmltv-devel] new tv grabber candidate for spain

[CandU _ <can...@ho...>]

Hi Mattias,


>>I've written a new xmltv grabber for my own use and thought it might be 
>>worth sending it back here. It's not so amazingly well written but it 
>>works for my purposes.
>>
>I ran tv_validate_grabber against your code and it passed all tests except 
>one: the grabber uses invalid xmltvids for some channels. An xmltvid must 
>be a valid dns-name which means that it cannot contain '+'.
>

Aha, there's a validator, cool, saves me asking dumb questions. The + thing 
should be easily fixed.

>I also had a quick look at the code and it looked good.

Thanks, I'm not a perl programmer by nature (more C/C++ based), so it's 
difficult to tell how good I'm doing.

>
>>* getting descriptions is much slower and a lot of programmes don't have 
>>them, so this is turned off via a variable (probably should be a command 
>>option)
>>
>I agree with Robert here that you should ask during --configure if the 
>grabber should download descriptions or not.

Sounds like a plan. I'll look into how to do that.

>>I've attached the script in it's current version. I'm prepared to work 
>>further on it and maintain it if it's going to be included.
>>
>I vote that we should give you CVS access so you can commit and maintain 
>your grabber. Do you have a sourceforge account?

I just made one, the user name is: candu_sf

I'm relatively used to CVS, so that shouldn't be a problem.

Cheers,

// candu

_________________________________________________________________
Is your PC infected? Get a FREE online computer virus scan from McAfee® 
Security. http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963