XMLStarlet command line XML toolkit / Bugs / #100 invalid free due to array modification in pyxStartElement

invalid free due to array modification in pyxStartElement

#100 invalid free due to array modification in pyxStartElement

Status: closed-fixed

Owner: nobody

Labels: main code (54)

Priority: 5

Updated: 2012-12-28

Created: 2012-12-12

Creator: Claudio Bley

Private: No

In function pyxStartElement, qsort is used to sort the attributes argument in place.

Since libxml2 keeps track of which attributes have been allocated and which not, this may lead to a program crash when pyxStartElement reorders the elements of the attributes array.

Patch attached.

Discussion

Claudio Bley - 2012-12-12

fix_pyx_crash.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Claudio Bley - 2012-12-12

summary: invalid free due attributes modification in pyxStartElement --> invalid free due to array modification in pyxStartElement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Noam Postavsky - 2012-12-14

Thanks, I applied your patch as commit 9a3a1862b3f315f8bd4cec1b9347cdd9180b4e71.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Noam Postavsky - 2012-12-14

status: open --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Noam Postavsky - 2012-12-28

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Noam Postavsky - 2012-12-28

Fixed in 1.4.2

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

invalid free due to array modification in pyxStartElement

Group

Searches

Help

#100 invalid free due to array modification in pyxStartElement

Discussion