[xml-cppdom-checkins] SF.net SVN: xml-cppdom:[640] trunk/cppdom

[<pat...@us...>]

Revision: 640
          http://xml-cppdom.svn.sourceforge.net/xml-cppdom/?rev=640&view=rev
Author:   patrickh
Date:     2010-03-06 16:19:42 +0000 (Sat, 06 Mar 2010)

Log Message:
-----------
It is unwise to have a polymorphic type entirely inlined in a header. The
base type needs to be compiled into the defining translation unit.

Modified Paths:
--------------
    trunk/cppdom/cppdom.cpp
    trunk/cppdom/cppdom.h

Modified: trunk/cppdom/cppdom.cpp
===================================================================
--- trunk/cppdom/cppdom.cpp	2010-03-06 16:15:59 UTC (rev 639)
+++ trunk/cppdom/cppdom.cpp	2010-03-06 16:19:42 UTC (rev 640)
@@ -1087,4 +1087,49 @@
       out.close();
    }
 
+   EventHandler::EventHandler()
+   {
+      /* Do nothing. */ ;
+   }
+
+   EventHandler::~EventHandler()
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::startDocument()
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::endDocument()
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::processingInstruction(Node&)
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::startNode(const std::string&)
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::parsedAttributes(Attributes&)
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::endNode(Node&)
+   {
+      /* Do nothing. */ ;
+   }
+
+   void EventHandler::gotCdata(const std::string&)
+   {
+      /* Do nothing. */ ;
+   }
+
 }

Modified: trunk/cppdom/cppdom.h
===================================================================
--- trunk/cppdom/cppdom.h	2010-03-06 16:15:59 UTC (rev 639)
+++ trunk/cppdom/cppdom.h	2010-03-06 16:19:42 UTC (rev 640)
@@ -822,36 +822,31 @@
    {
    public:
       /** Constructor. */
-      EventHandler() {}
+      EventHandler();
 
       /** Destructor. */
-      virtual ~EventHandler() {}
+      virtual ~EventHandler();
 
       /** Called when parsing of an xml document starts. */
-      virtual void startDocument() {}
+      virtual void startDocument();
 
       /** Called when ended parsing a document. */
-      virtual void endDocument() {}
+      virtual void endDocument();
 
       /** Called when parsing a processing instruction. */
-      virtual void processingInstruction(Node& pinode)
-      {  cppdom::ignore_unused_variable_warning(pinode);}
+      virtual void processingInstruction(Node& pinode);
 
       /** Called when start parsing a node. */
-      virtual void startNode(const std::string& nodename)
-      { cppdom::ignore_unused_variable_warning(nodename); }
+      virtual void startNode(const std::string& nodename);
 
       /** Called when an attribute list was parsed. */
-      virtual void parsedAttributes(Attributes& attr)
-      { cppdom::ignore_unused_variable_warning(attr); }
+      virtual void parsedAttributes(Attributes& attr);
 
       /** Called when parsing of a node was finished. */
-      virtual void endNode(Node& node)
-      { cppdom::ignore_unused_variable_warning(node);}
+      virtual void endNode(Node& node);
 
       /** Called when a cdata section ended. */
-      virtual void gotCdata(const std::string& cdata)
-      { cppdom::ignore_unused_variable_warning(cdata); }
+      virtual void gotCdata(const std::string& cdata);
    };
 
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.