#328 Bookmarks menu not correctly read from xferc in current session

[Mikael Löfgren]

Hi and thank you for a great file manager!

I have upgraded to xfe v2.1.13 (from v1.43.2 ..yes I know I am a slow) and discovered that the Bookmarks menu is not working as intended in this version:

When adding a new bookmark:

• The current xfe session will read in all bookmarks again from xferc, but this list does not replace the list of bookmarks already read when the window was created, so all bookmarks will be listed twice. If yet another bookmark is added from the same xfe session; the all bookmarks will be displayed three times in the Bookmarks menu and so on.

• If several xfe sessions/windows are open at the same time; then only the session used to add a new bookmark will show the new bookmark in the Bookmarks menu. The other sessions will not read in the newly added bookmark from xferc.

• The default icon, or any icon selected, when adding a bookmark will not be displayed in the Bookmarks menu. It looks like space is reserved for a 16x16px icon to the left of each bookmark in the menu, but no icon is displayed.

'Remove All Bookmarks' will not have any effect until restarting xfe, because the current xfe session, as well as any other already open xfe session, will not read in the changes from xferc.

An option to remove individual bookmarks and sort them is on my wishlist ;) It can be done by editing xferc, but feels a bit like a hack.

[Roland Baudin]

I can't reproduce the issue, except point #2 (several Xfe sessions). I suggest you start with a fresh Xfe profile (since you had a very old version before). Point 3 (missing icon) suggest a theme configuration problem (do you have only one version of Xfe installed?).
So do: mv ~.config/xfe ~.config/xfe.bak and tell me if the problem still arises...

[Mikael Löfgren]

Hi Roland and thank you for looking into this so quickly.
I have a feeling you are looking at the bookmarks representation in the side panel, but I mean the drop-down Bookmarks menu.
I agree that icons are correctly displayed in the Bookmarks side panel and the side panel is correctly updated when new bookmarks are added in the current xfe session (but not in any other open xfe sessions).
In the drop-down menu however i can reproduce the bugs I reported also with a completely fresh '~/.config/xfe' dir.
Please look at the attached screenshot: There you can see that the bookmarks are listed over and over again in the drop-down menu after adding new bookmarks in the current session. And no icons are shown to the left of each bookmark (in case icons are supposed to be displayed in the drop-down menu as well?).
And yes, I only have one version of xfe installed. I purged the old version, wiped '/usr/share/xfe' and wiped '~/.config/xfe' before installing the new version.
Cheers,
Mikael

[Mikael Löfgren]

I also just realized that the possibility to sort, edit and remove individual bookmarks are already implemented in the Bookmarks side panel, even though not available in the Bookmarks drop-down menu. Nice :)

[Roland Baudin]

OK, reproduced and fixed! Thanks for the feedback.
The fix will be available in the next release.

[Mikael Löfgren]

Thank you.
This ticket can be closed now.