#323 XFE crashes when deleting file to trash from mounted hdd

[Alexander Parish]

Hi there

I have the problem that when I delete some files (but not always) on a mounted hdd xfe crashes.

I am using MX Linux 25.x with xfe version 2.1.6
I have a folder structure /home/Downloads on sda
/home/Downloads/bits is on sdb. IE /dev/sdb is mounted to bits.

If I delete a file to the trash from /home/Downloads/bits (usually a larger video file about 800Mb) xfe crashes.

I downloaded the deb file for version 2.1.9 and had the same problem.
I force installed version 2.0.1 and did not have the problem.

Is there a crash log to look at?

[Mamoru TASAKA]

For me, I get the following backtrace (when trying to move 31G file to Trash):
Using xfe 2.1.9

File.cpp:2669:23: runtime error: member call on null pointer of type 'struct FXLabel'

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff753b968 in FX::operator!= (s1=..., s2=...) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXString.cpp:1980
1980      return compare(s1.str,s2.str)!=0;

(gdb) bt
#0  0x00007ffff753b968 in FX::operator!= (s1=..., s2=...) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXString.cpp:1980
#1  0x00007ffff74cbe8b in FX::FXLabel::setText (this=this@entry=0x0, text=...) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXLabel.cpp:438
#2  0x00005555556c5b43 in File::onCopySpeed (this=0x7d5ff4c36180) at File.cpp:2669
#3  0x00007ffff7439474 in FX::FXObject::tryHandle (this=<optimized out>, sender=0x7dbff4be0080, sel=<optimized out>, ptr=<optimized out>) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXObject.cpp:292
#4  FX::FXApp::handleTimeouts (this=this@entry=0x7dbff4be0080) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:1412
#5  0x00007ffff7439505 in FX::FXApp::getNextEvent (this=0x7dbff4be0080, ev=..., blocking=false) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:1847
#6  0x0000555555adcdf1 in FX::FXApp::runOneEvent (this=0x7dbff4be0080, blocking=false) at main.cpp:180
#7  0x00007ffff7435512 in FX::FXApp::runModalWhileEvents (this=0x7dbff4be0080, window=<optimized out>) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:3125
#8  0x00005555556ce82e in File::copyfile (this=this@entry=0x7d5ff4c36180, source=..., target=..., hsourcesize=..., sourcesize=sourcesize@entry=0, tstart=tstart@entry=0, preserve_date=<optimized out>) at File.cpp:747
#9  0x00005555556d3743 in File::copyrec (this=this@entry=0x7d5ff4c36180, source=..., target=..., hsourcesize=..., sourcesize=sourcesize@entry=0, tstart=tstart@entry=0, inodes=<optimized out>, preserve_date=<optimized out>) at File.cpp:1086
#10 0x00005555556d5a61 in File::copy (this=this@entry=0x7d5ff4c36180, source=..., target=..., hsourcesize=..., sourcesize=sourcesize@entry=0, tstart=tstart@entry=0, confirm_dialog=<optimized out>, preserve_date=<optimized out>)
    at File.cpp:1247
#11 0x00005555556d90dd in File::fmove (this=this@entry=0x7d5ff4c36180, source=..., target=..., hsourcesize=..., sourcesize=sourcesize@entry=0, tstart=tstart@entry=0, restore=<optimized out>) at File.cpp:1741
#12 0x000055555578785e in FilePanel::onCmdFileTrash (this=0x7d5ff4c29580) at FilePanel.cpp:2836
#13 0x00007ffff74ed810 in FX::FXObject::tryHandle (this=<optimized out>, sender=<optimized out>, sel=<optimized out>, ptr=0x1) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXObject.cpp:291
#14 FX::FXMenuCommand::onButtonRelease (this=0x7d1ff4c72a40) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXMenuCommand.cpp:175
#15 0x0000555555aa82c9 in FX::FXApp::dispatchEvent (this=0x7dbff4be0080, ev=...) at /usr/src/debug/xfe-2.1.9-0.100.fc45.x86_64/src/foxhacks.cpp:1904
#16 0x0000555555add115 in FX::FXApp::runOneEvent (this=0x7dbff4be0080, blocking=<optimized out>) at main.cpp:193
#17 0x00007ffff743a5c9 in FX::FXApp::runModalWhileShown (this=0x7dbff4be0080, window=window@entry=0x7d0ff4d29a00) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:3171
#18 0x000055555579f638 in FilePanel::onCmdPopupMenu (this=0x7d5ff4c29580, sender=<optimized out>, sel=<optimized out>, ptr=<optimized out>) at FilePanel.cpp:5074
#19 0x00007ffff74eabbd in FX::FXObject::tryHandle (this=<optimized out>, sender=<optimized out>, sel=<optimized out>, ptr=<optimized out>) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXObject.cpp:292
#20 0x00005555557f7bc9 in IconList::onRightBtnRelease (this=0x7d8ff4c6b680, ptr=0x7dbff4be0280) at IconList.cpp:3929
#21 0x0000555555aa2a2b in FX::FXApp::dispatchEvent (this=0x7dbff4be0080, ev=...) at /usr/src/debug/xfe-2.1.9-0.100.fc45.x86_64/src/foxhacks.cpp:1893
#22 0x0000555555add115 in FX::FXApp::runOneEvent (this=0x7dbff4be0080, blocking=<optimized out>) at main.cpp:193
#23 0x00007ffff743525d in FX::FXApp::run (this=this@entry=0x7dbff4be0080) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:3092
#24 0x00005555555a499c in main (argc=<optimized out>, argv=<optimized out>) at main.cpp:584

[Mamoru TASAKA]

So looks like

• in FilePanel::onCmdFileTrash (in FilePanel.cpp), File object is created with DELETE operation: in this case in File ctor datalabel is set to NULL (timelabel is also NULL)
• But in File::onCopySpeed this tries to access datalabel

[Roland Baudin]

OK, I reproduced the issue. Thanks for the investigations.

[Roland Baudin]

Here is a File.cpp replacement that should fix the crash. Could you test it please?

[Mamoru TASAKA]

Looks like working for me, thank you.

[Alexander Parish]

Unfortunately I don't know how to compile this to test it.

[Roland Baudin]

No problem, I released to day a new version, so you can test. But the bug is fixed.

[Alexander Parish]

Worked for me too.
Thanks