Re: [Xen-devel] [PATCH]local apic initialization

[Keir F. <Kei...@cl...>]

On 25 Mar 2005, at 21:23, Ian Pratt wrote:

> It didn't apply totally cleanly, but I fixed it up, and it booted OK 
> for
> me.
>
> How much testing have you been able to give the patch?
>
> I'm not sure that some of the #if 0's are actually going to help from a
> maintenance POV, so it might actually be better to remove any whole
> functions etc that aren't used.

I'd make it a pre-condition of acceptance: the patch will be much 
smaller since a lot of the added code fragments are actually if 0'ed 
out. It makes it hard to work out what moving parts have actually 
changed.

  -- Keir