Re: [Xen-devel] [PATCH][RESUBMIT] tools top level makefile cleanup

[Adam H. <do...@br...>]

On Fri, 25 Mar 2005, Adam Heath wrote:

> On Fri, 25 Mar 2005, Jerone Young wrote:
>
> > +all: check
> > + @for subdir in $(SUBDIRS); do \
> > + $(MAKE) -C $$subdir $@ || exit -1; \
> > + done
>
> How is this a valid makefile?  Where's the tab?

Please use "@set -e; for ...", and remove the "|| exit -1".

Besides, exit -1 is poor, it s/b a positive number.  It's not really possible
to exit with a negative value.