[xdvi-core] [ xdvi-Bugs-764559 ] forward search does not keep position

[SourceForge.net <no...@so...>]

Bugs item #764559, was opened at 2003-07-02 13:37
Message generated for change (Comment added) made by stefanulrich
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=377580&aid=764559&group_id=23164

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Ulrich Scholz (hagbart)
Assigned to: Stefan Ulrich (stefanulrich)
Summary: forward search does not keep position

Initial Comment:
forward search (the ability to jump to a certain
position in a dvi-file) does not keep the position
(button k), at least not for me.

----------------------------------------------------------------------

>Comment By: Stefan Ulrich (stefanulrich)
Date: 2003-07-09 13:22

Message:
Logged In: YES 
user_id=177175

> BTW, the same problem happens if you go to another page by
> clicking on the page list.  

Indeed, but that's another bug; all occurrences of `home);'
in pagesel.c need to be replaced by `resource.keep_flag ?
NULL : home);'. Will fix this ASAP.

> If you think that keep position is a problem in connection
> with wide jumps in the document

No, it's not related to distance; my argument with forward
search was that we need some way to indicate the target of
the forward search even when `keep' is active, else the user
might think forward search didn't work at all. One
possibility to do this is to scroll, another (probably
cleaner) way is to indicate the location if it's outside the
visible area with an arrow or something.

Your report also seems to show that xdvi generally scrolls
too much (even if the target point is already visible). I've
started playing around with the offsets (they are a bit
large), but haven't finished yet. I'll send another followup
if it's finished, maybe you can then try it again to see if
it still happens.

If you'd like a quick fix now, you could change the
following lines in `scroll_page_if_needed', file x_util.c:

    Position drawing_x, drawing_y, drawing_h, clip_x,
clip_y, clip_h, clip_w;
    int test_scroll, need_v_scroll = 0, need_h_scroll = 0;
    Boolean reset_autoscroll = False;

by:

    Position drawing_x, drawing_y, drawing_h, clip_x,
clip_y, clip_h, clip_w;
    int test_scroll, need_v_scroll = 0, need_h_scroll = 0;
    Boolean reset_autoscroll = False;

    if (resource.keep_flag)
	return;

and recompile.


----------------------------------------------------------------------

Comment By: Ulrich Scholz (hagbart)
Date: 2003-07-09 12:53

Message:
Logged In: YES 
user_id=810188

BTW, the same problem happens if you go to another page by
clicking on the page list.  

If you think that keep position is a problem in connection
with wide jumps in the document, maybe you should provide
two modes of keep position: The regular one and an "really,
really keep the position"

----------------------------------------------------------------------

Comment By: Stefan Ulrich (stefanulrich)
Date: 2003-07-02 14:45

Message:
Logged In: YES 
user_id=177175

> All pages in my document are formatted the same
> way, so that extra scrolling is annoying.

so maybe it is really scrolling too much? Would the
upper-left corner of the `highlighted' rectangular region
also be visible without scrolling? (Plus a small offset of
about 25 pixels - maybe that offset too large?)

I'll consider preventing scrolling if the `keep' flag is
active, but this might be an independent problem.

----------------------------------------------------------------------

Comment By: Ulrich Scholz (hagbart)
Date: 2003-07-02 14:25

Message:
Logged In: YES 
user_id=810188

I use forward search for - well - the obvious: to navigate
in a large
document.  All pages in my document are formatted the same
way, so that extra
scrolling is annoying.

Nevertheless, you have a point here.

> to bring the target of the search back into focus when
it's off, otherwise
> one might not see anything.

Mmh, I'm not sure about the right (read: the most intuitive)
way, but in my
opinion, the (forced) extra scrolling is the wrong.

> Or should xdvi not scroll at all if `keep-position' is
> active? 

That is what I did expect.

>  Maybe do something different, like show an arrow if the
position is off?

Maybe.  But don't you put a lot of work into xdvik anyway?


----------------------------------------------------------------------

Comment By: Stefan Ulrich (stefanulrich)
Date: 2003-07-02 14:06

Message:
Logged In: YES 
user_id=177175

> forward search (the ability to jump to a certain
> position in a dvi-file) does not keep the position 

I did this scrolling on purpose, to bring the target of the
search back into focus when it's off, otherwise one might
not see anything. So I decided to treat forward search as a
request of the user `view the text in this certain region',
as if the user would scroll to the region.

Maybe it does `too much' and scroll the page also when the
location is already visible? (In that case, I'd like to send
you a patch that outputs some more debugging information).

Or should xdvi not scroll at all if `keep-position' is
active? Maybe do something different, like show an arrow if
the position is off?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=377580&aid=764559&group_id=23164