[Xdoclet-user] a coule of bugs

[Glenn R. K. <gr...@ne...>]

1) Possible bug with ejb-ref tag:

According to the docs, for ejb-ref tags, ref-name is optional and if
_not_ specified then the reference name is ejb-name prefixed by a ejb/.

The problem is that "ejb/" is still being added as a prefix even if
ref-name is specified.  We use ref-name like the following, so we end up
with "ejb/ejb/fc/CertLocal" in the ejb-jar.xml

 * @ejb:ejb-ref ejb-name="fc/Cert" ref-name="ejb/fc/CertLocal"
view-type="local"


2) API inconsistency for ejb-external-ref

IMHO I think that ejb-external-ref should behave like the ejb-ref tag,
in that it should take the (optional) ref-name attribute and if
specified, use as is, if not, the use the ejb-name prefixed by ejb.

I realize for ejb-ref ejb-name, xdoclet will error/warn if it can't find
the matching ejb-name but for ejb-external-ref this is not the case
(since its in a different package and can't match it up) so you can
really just use anything for ejb-name, but I think that's potentially
confusing or at least a different behaviour.  Also, adding ref-name
shouldn't break existing users, and really only the ejb-body.j rule for
ejb-external-ref/ejb-ref-name needs to be copied from
ejb-ref/ejb-ref-name.

Thoughts?

Glenn