#384 2.0.4 nick label doesn't change in new channel window

[Anonymous]

When channels are configured to open in new windows, if
you change your nick and then join a channel, the nick
label next to the input box of the new window doesn't
get updated properly.

I sifted through the code a bit and found a couple of
solutions, but the gui code is too involved for me to
know if these 'solutions' might break the code in new
and exciting ways ;)
Hope this helps, though:

in maingui.c, mg_create_entry:

gui->nick_label = but = gtk_button_new_with_label
(prefs.nick1);

- This seems to be the origin. Changing prefs.nick1
with sess->server->nick when connected would seem
logical and fixes it.

or

the code for updating the label seems to be in mg_populate:

/* this one flickers, so only change if necessary */
if (strcmp (sess->server->nick, gtk_button_get_label
(GTK_BUTTON (gui->nick_label))) != 0)
gtk_button_set_label (GTK_BUTTON (gui->nick_label),
sess->server->nick);

- but mg_populate doesn't seem to be getting called for
windows which are not tabs. Adding a call to
mg_populate in the "if (!tabs)" clause in
mg_changui_new seems to fix it. Removing the "return;"
at the end of this block also seems to do the trick,
but again- I've no idea if this might break other things.

Regards,
Tom.