[ xcat-Bugs-3078101 ] tabgrep no longer works returns all tables

[SourceForge.net <no...@so...>]

Bugs item #3078101, was opened at 2010-09-29 15:47
Message generated for change (Tracker Item Submitted) made by lissav
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1006945&aid=3078101&group_id=208749

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 2.6
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Lissa Valletta (lissav)
Assigned to: chris hardee (cjhardee)
Summary: tabgrep no longer works returns all tables 

Initial Comment:
I found this in 2.6 but probably is broken in 2.5.  

The tabgrep <nodename> command no longer selects only the tables where the nodename apprears,  It returns all tables that have a node attribute.  
It seems the changes in getNodeAttribs  may have caused this.    Maybe the below checking for tabgrep is no longer valid.   Jarrod mentions you now return 
"getNodeAttribs returns an empty hash instead of undef".     The change may have broken other code.  Unless we change back to undef,  we will need to check all calls. 

This is the code in tabutils.pm   the tabgrep routine. 
foreach (@tablist)
    {
        my $tab = xCAT::Table->new($_);
        unless ($tab) { next; }
        if ($tab and $tab->getNodeAttribs($node->[0], ["node"]))
        {
            $callback->({data => [$_]});
        }
        $tab->close;
    }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1006945&aid=3078101&group_id=208749