Menu ▾ ▴

#4691 Use a consistent log tag for xCAT log

2.11
closed
GONG Jie
log (1)
postscripts
5
2015-07-27
2015-06-04
GONG Jie
No

In the source of xCAT, logger was used to write messages to syslog.

In most of the case, xCAT user logger -t xcat, in some case xCAT use logger -t xCAT, in some rare case, xCAT even use something else. Below is a quick summary.

TAG        FREQ
---------+-----
xcat     |  388
xCAT     |  159
[no tag] |   15
gmonfail |    2
---------+-----
TOTAL       564

xCAT needs a consistent log tag for all the logs. Thus, end user can filter the logs later more easier.

Below are commands I used to count the lines.

***** 2029 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -- 'logger' . | wc -l
597
***** 2030 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -E -- 'logger .*-t *x[Cc][Aa][Tt]' . | wc -l
547
***** 2031 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -E -- 'logger .*-t *xcat' . | wc -l
388
***** 2032 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -E -- 'logger .*-t *xCAT' . | wc -l
159
***** 2050 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -E -- 'logger .*-t +[^ x][^Cc][^Aa][^Tt]' . | wc -l
2
***** 2083 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -E -- 'logger +[^ -]' . | wc -l
15
***** 2069 ** pts/9 * neo@wolfram:~/src/xcat-core@HEAD *****
$ grep -r -- logger . | grep -v -E -- '-t *x[Cc][Aa][Tt]' | grep -v -E -- '-t gmonfail' | grep '#' | wc -l
5

Discussion

  • GONG Jie

    GONG Jie - 2015-06-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,6 @@
 In the source of xCAT, logger was used to write messages to syslog.

-In most of the case, xCAT user ``logger -t xcat'', in some case xCAT use ``logger -t xCAT'', in some rare case, xCAT even use something else. Below is a quick summary.
+In most of the case, xCAT user ``logger -t xcat``, in some case xCAT use ``logger -t xCAT``, in some rare case, xCAT even use something else. Below is a quick summary.

     TAG        FREQ
     ---------+-----
     

  • Guang Cheng Li

    Guang Cheng Li - 2015-06-17

    Could be part of the feature "syslog enhancements".

     

  • Guang Cheng Li

    Guang Cheng Li - 2015-06-17
    • assigned_to: GONG Jie
     

  • Victor Hu

    Victor Hu - 2015-06-17

    I'd like to take this bug and work on it if possible.

     

  • Guang Cheng Li

    Guang Cheng Li - 2015-07-02
    • component: unknown --> postscripts
    • Milestone: 2.10 --> 2.11
     

  • Guang Cheng Li

    Guang Cheng Li - 2015-07-02

    The current plan is that we will work on the syslog enhancements in xCAT 2.11, moving this bug to 2.11.

     

  • GONG Jie

    GONG Jie - 2015-07-06
    • status: open --> pending
     

  • GONG Jie

    GONG Jie - 2015-07-06 
    commit ce9430d28040de02d3f3e31e1b8f17b804aa7e43
Author: GONG Jie <gongjie@linux.vnet.ibm.com>
Date:   Thu Jul 2 14:58:53 2015 +0800

    Fix sourceforge bug #4691 Use a consistent log tag for xCAT log

commit ca4437270a31d256acbaa496d77bb11875de2cd3
Author: GONG Jie <gongjie@linux.vnet.ibm.com>
Date:   Wed Jul 1 18:03:36 2015 +0800

    Fix sourceforge bug #4691 Use a consistent log tag for xCAT log
     

    Last edit: GONG Jie 2015-07-06

  • GONG Jie

    GONG Jie - 2015-07-27

    Will close this one.

     

  • GONG Jie

    GONG Jie - 2015-07-27
    • status: pending --> closed
     
MongoDB Logo MongoDB