Re: [Xbox-linux-cvs] kernel/drivers/video/xbox xcalibur.c,NONE,1.1 xcalibur.h,1.2,1.3

[<a.o...@bl...>]

On Sun, Aug 01, 2004 at 01:01:09PM -0700, dav...@us... wrote:
> --- NEW FILE: xcalibur.c ---
> /*
>  * linux/drivers/video/xbox/xcalibur.c - Xbox driver for Xcalibur encoder
>  *
>  * Maintainer: David Pye (dmp) <dm...@da...>
>  *
>  * This file is subject to the terms and conditions of the GNU General Public
>  * License.  See the file COPYING in the main directory of this archive
>  * for more details.
>  *
>  * Known bugs and issues:
>  *
>  * It doesnt DO anything yet!
> */
> #include "xcalibur.h"
> #include "encoder.h"
> 
> typedef struct _xcalibur_sync {
> 	U032	htotal;
> 	U032	vtotal;
> 	U032	hsyncstart;
> 	U032 	hsyncend;
> 	U032	vsyncstart;
> 	U032	vsyncend;
> } XCALIBUR_SYNC;
 
Another rivafbism. What's wrong with using the more
intuitive `u32' (include/linux/types.h) ?

> static const XCALIBUR_SYNC xcalibur_sync[2][1] = {
> {	// NTSC MODES
> 	{780, 525, 682, 684, 486, 488},
> },
> {	// PAL MODES
> 	{800, 520, 702, 726, 480, 490},
> }
> };