xarchiver / Patches / #12 Cumulative patch + xz, tar.xz, rar5 (new version) support

Markus Koschany - 2013-12-06

Your e-mail address is invalid, so here is my reply to your private mail.

Hi!

On 06.12.2013 11:47, tbox wrote:

hello,

I made a cumulative patch (including all previous patch I can find on
the web)
plus the full support of xz, tar.xz and rar5 archive format coded by me.

I hope it could be merged with the current version of xarchiver.

Feel free to contact me

Thanks for your e-mail.

In short: xz-support would be really nice but please split the jumbo
patch into smaller patches, so that it is easier to review.

I'm generally interested in applying a complete xz-support patch for
xarchiver. I would prefer if you could divide the jumbo patch into
several smaller patches where each patch addresses one issue, so that it
is easier for me to review the changes.

I have already tried to add xz-support to xarchiver and used a patch
from Archlinux/Slackware as a starting point.

http://anonscm.debian.org/gitweb/?p=collab-maint/xarchiver.git;a=shortlog;h=refs/heads/xz-support

Unfortunately the patch is not complete and the command-line usage for
xarchiver and xz seems to be broken.

So if you can create a working feature patch for xz-support, that also
works from the command-line, I'm willing to apply it to the Debian
package of xarchiver.

Regarding RAR5 support, well, it's a proprietary format and I don't
really care much about it.

Also thanks for reporting your patches upstream. I think this is the
correct way forward.

Regards,

Markus

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Teo Box - 2013-12-06
  
  Hi Markus,
  
  Thanks for your reply.
  
  I'll prepare a patch focused only on xz / tar.xz
  
  actually, my patch enable (xz/tar.xz) support for interactive add(with
  compression level)/extract and command line option.
  
  It should be done on monday, have a nice week-end
  
  Teo
  
  Last edit: Teo Box 2013-12-09
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Teo Box - 2013-12-09
    
    Hi Marcus,
    
    I've posted the new patch focused on xz / tar.xz only
    
    Regards
    Teo
    
    Last edit: Teo Box 2013-12-09
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Markus Koschany - 2013-12-10
      
      Hello Teo,
      
      On 09.12.2013 13:18, Teo Box wrote:
      
      Hi Marcus,
      
      I've posted the new patch focused on xz / tar.xz only
      
      Unfortunately this file still contains unrelated patches for other
      issues. The xz-patch should only add xz-support and nothing else. Who
      wrote this patch? Can you provide a link?
      
      I dont know how to do this : "Also thanks for reporting your patches
      upstream. I think this is the
      correct way forward."
      
      Please note I'm not the upstream developer of xarchiver but merely the
      Debian maintainer. You already reported your feature request "upstream"
      at sourceforge.net and new features should be added by the developer(s)
      of xarchiver.
      
      If you want me to include this patch in Debian it should be well tested.
      Are tar.xz files handled correctly by the GUI? Can you open and
      manipulate xz files from the command-line?
      
      Regards,
      
      Markus
      
      signature.asc
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-12

Hi markus,

1) this file still contains unrelated patches for other issues.
-> Yes, because without these fix xarchiver is unstable, even in a normal use

2) Who wrote this patch?
-> I'm the author of this patch (proudly !)

3) this patch in Debian it should be well tested.
-> I test as far as I can, in GUI and command line, without trouble. (when the fix discussed in 1, is applied)

I'll can remove other fix in the xz patch, but expect undefined behaviour.

let's me know

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-13

Hi Markus

please find below a xz/tar.xz patch (cleaned from other patch)

I've tested Add/Extract/test from cmd line and GUI

Regards
Teo

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Markus Koschany - 2013-12-15
  
  Hi Teo,
  
  thanks, your patch looks fine except one issue that should be addressed
  first.
  
  If I try to rename or delete files with the GUI in an opened tar.xz
  archive, the application segfaults. Could you try to fix this behaviour?
  An option might be to disable renaming and deleting of files in tar.xz
  archives.
  
  I have also spotted another bug that appears being unrelated to your patch.
  
  xarchiver -d filename
  
  If I then choose an already existing archive, the application will also
  segfault.
  
  Regards,
  
  Markus
  
  On 13.12.2013 11:47, Teo Box wrote:
  
  Hi Markus
  
  please find below a xz/tar.xz patch (cleaned from other patch)
  
  I've tested Add/Extract/test from cmd line and GUI
  
  Regards
  Teo
  
  Attachment: xarchiver-0.5.2-xz-support-pure.patch.gz (4.1 kB;
  application/x-gzip)
  
  [patches:#12] http://sourceforge.net/p/xarchiver/patches/12/
  Cumulative patch + xz, tar.xz, rar5 (new version) support
  
  Status: open
  Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
  Last Updated: Thu Dec 12, 2013 02:41 PM UTC
  Owner: Giuseppe Torelli
  
  Helo,
  I made a cumulative patch (including all previous patch I can find on
  the web)
  plus the full support of xz, tar.xz and rar5 archive format coded by me.
  
  please read 'note.txt' before compilling.
  
  My two cents.
  Teo
  
  Sent from sourceforge.net because you indicated interest in
  https://sourceforge.net/p/xarchiver/patches/12/
  
  To unsubscribe from further messages, please visit
  https://sourceforge.net/auth/subscriptions/
  
  Related
  
  Patches: #12
  
  signature.asc
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Teo Box - 2013-12-16
    
    Hi Markus
    
    please find the updated patch
    
    Fixed:
    - tar.xz : delete/rename file in archive
    
    Cmd line
    Fixed:
    the (-d) option was buggy when there is only one file
    
    Tested :
    xarchiver -d ./src/*.c
    
    xarchiver -a /tmp/test.tar.xz
    
    xarchiver -x /tmp /tmp/test.tar.xz
    
    Regards
    Teo
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Markus Koschany - 2013-12-17
      
      Hi Teo,
      
      many thanks for your efforts. I tried to test your new patch but
      recognized that it contains some unrelated changes. The diff between
      your old and new patch is attached. Are your sure that you submitted the
      right patch because e.g. I can't see a fix for the -d option.
      
      Thanks
      
      Markus
      
      diff-between-old-and-new.patch
      
      signature.asc
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Markus Koschany - 2013-12-17
      
      By the way I'd be glad if you could rebase the patch against the current
      master or xz-support branch of the Debian package. That helps to speed
      up things.
      
      http://anonscm.debian.org/gitweb/?p=collab-maint/xarchiver.git
      
      signature.asc
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-17

You're right, I put the wrong patch :(

here is the good patch rebase againt the clean 0.5.2 sources.

I need to form myself about collaborative work !

(the Debian package with xz-support is the file "xarchiver-e70c9e2.tar.gz" ?? )

Regards
Teo

xarchiver-0.5.2-xz-support-pure.patch.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Markus Koschany - 2013-12-18
  
  Hello Teo,
  
  now deleting of files works, thanks! However I still get a segfault,
  when I try to rename a file. That's the only remaining issue which
  bothers me, otherwise your patch looks fine.
  
  That's the official tarball from Debian:
  
  http://ftp.de.debian.org/debian/pool/main/x/xarchiver/xarchiver_0.5.2+20130119+dfsg.orig.tar.gz
  
  I can recommend Git for collaborative work. You could simply clone the
  Debian repository of Xarchiver and work on that.
  
  http://anonscm.debian.org/gitweb/?p=collab-maint/xarchiver.git
  
  I intend to include your patch with the next regular upload of
  xarchiver, if there is a solution for the renaming issue.
  
  Shall I credit you with your real name or do you prefer Teo Box?
  
  Please confirm that you provide your patch under the GPL-2 or later license.
  
  If you are looking for further challenges...the -m option is also quite
  buggy, at least I can't extract multiple archives.
  
  Regards,
  
  Markus
  
  On 17.12.2013 19:31, Teo Box wrote:
  
  You're right, I put the wrong patch :(
  
  here is the good patch rebase againt the clean 0.5.2 sources.
  
  I need to form myself about collaborative work !
  
  (the Debian package with xz-support is the file
  "xarchiver-e70c9e2.tar.gz" ?? )
  
  signature.asc
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Teo Box - 2013-12-18
    
    Hi Markus,
    
    Many thanks for all these informations.
    
    For a strange reason my patch doesnt apply correclty (but doesnt warn or
    echo error) and half of the code was not changed...
    
    I made this one with git diff, (thanks to you) , and add/delete/rename file
    in archive should work now.
    
    I'm not afraid of "-m" option , I can deal with it :)
    
    You can credit my real names, "Frederick Guerin",
    
    and of course all of this is under GPL v2 license.
    
    Regards
    Teo
    
    On Wed, Dec 18, 2013 at 5:03 PM, Markus Koschany apoleon@users.sf.netwrote:
    
    Hello Teo,
    
    now deleting of files works, thanks! However I still get a segfault,
    when I try to rename a file. That's the only remaining issue which
    bothers me, otherwise your patch looks fine.
    
    That's the official tarball from Debian:
    
    http://ftp.de.debian.org/debian/pool/main/x/xarchiver/xarchiver_0.5.2+20130119+dfsg.orig.tar.gz
    
    I can recommend Git for collaborative work. You could simply clone the
    Debian repository of Xarchiver and work on that.
    
    http://anonscm.debian.org/gitweb/?p=collab-maint/xarchiver.git
    
    I intend to include your patch with the next regular upload of
    xarchiver, if there is a solution for the renaming issue.
    
    Shall I credit you with your real name or do you prefer Teo Box?
    
    Please confirm that you provide your patch under the GPL-2 or later
    license.
    
    If you are looking for further challenges...the -m option is also quite
    buggy, at least I can't extract multiple archives.
    
    Regards,
    
    Markus
    
    On 17.12.2013 19:31, Teo Box wrote:
    
    You're right, I put the wrong patch :(
    
    here is the good patch rebase againt the clean 0.5.2 sources.
    
    I need to form myself about collaborative work !
    
    (the Debian package with xz-support is the file
    "xarchiver-e70c9e2.tar.gz" ?? )
    
    [patches:#12] http://sourceforge.net/p/xarchiver/patches/12/
    Cumulative patch + xz, tar.xz, rar5 (new version) support*
    
    Status: open
    Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
    Last Updated: Tue Dec 17, 2013 06:31 PM UTC
    Owner: Giuseppe Torelli
    
    Helo,
    I made a cumulative patch (including all previous patch I can find on the
    web)
    plus the full support of xz, tar.xz and rar5 archive format coded by me.
    
    please read 'note.txt' before compilling.
    
    My two cents.
    Teo
    
    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/xarchiver/patches/12/
    
    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/subscriptions/
    
    Related
    
    Patches: #12
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Markus Koschany - 2013-12-18
      
      Hi Teo,
      
      On 18.12.2013 21:38, Teo Box wrote:
      
      [...]
      
      I made this one with git diff, (thanks to you) , and add/delete/rename file
      in archive should work now.
      
      Hmm, did you forget to attach the new patch? :)
      
      Regards,
      
      Markus
      
      signature.asc
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-19

Doh! I do !

xz-support.patch.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Markus Koschany - 2013-12-20
  
  On 19.12.2013 10:31, Teo Box wrote:
  
  Doh! I do !
  
  Attachment: xz-support.patch.gz (4.5 kB; application/x-gzip)
  
  Thank you very much. The patch appears to work.
  
  Happy Christmas!
  
  signature.asc
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Teo Box - 2013-12-20
    
    HooHoo !
    
    Good news to ear,
    
    By working in the "-m" issue I made 3 other patch to fix other touble.
    
    but these patch apply only against your git repository, not the vanillia
    tar.gz on source forge.
    
    list of patch:
    -fix-multiextract
    -fix-icon-update
    -fix-unrar-can-add
    -add-test-support (for all tar and gz,xz,etc..)
    
    where do i send my patch ?
    
    Sould I post them on source forge anyway?
    
    have a good christmas too.
    
    Regards
    Teo
    
    On Fri, Dec 20, 2013 at 1:17 PM, Markus Koschany apoleon@users.sf.netwrote:
    
    On 19.12.2013 10:31, Teo Box wrote:
    
    Doh! I do !
    
    Attachment: xz-support.patch.gz (4.5 kB; application/x-gzip)
    
    Thank you very much. The patch appears to work.
    
    Happy Christmas!
    
    [patches:#12] http://sourceforge.net/p/xarchiver/patches/12/
    Cumulative patch + xz, tar.xz, rar5 (new version) support*
    
    Status: open
    Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
    Last Updated: Thu Dec 19, 2013 09:31 AM UTC
    Owner: Giuseppe Torelli
    
    Helo,
    I made a cumulative patch (including all previous patch I can find on the
    web)
    plus the full support of xz, tar.xz and rar5 archive format coded by me.
    
    please read 'note.txt' before compilling.
    
    My two cents.
    Teo
    
    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/xarchiver/patches/12/
    
    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/subscriptions/
    
    Related
    
    Patches: #12
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Giuseppe Torelli - 2013-12-20
      
      Yes please. I will do my best to apply them and release a 0.5.3 version.
      
      What about working on the 0.6 branch?
      
      Giuseppe
      On 20 Dec 2013 17:34, "Teo Box" tbox1@users.sf.net wrote:
      
      HooHoo !
      
      Good news to ear,
      
      By working in the "-m" issue I made 3 other patch to fix other touble.
      
      but these patch apply only against your git repository, not the vanillia
      tar.gz on source forge.
      
      list of patch:
      -fix-multiextract
      -fix-icon-update
      -fix-unrar-can-add
      -add-test-support (for all tar and gz,xz,etc..)
      
      where do i send my patch ?
      
      Sould I post them on source forge anyway?
      
      have a good christmas too.
      
      Regards
      Teo
      
      On Fri, Dec 20, 2013 at 1:17 PM, Markus Koschany <apoleon@users.sf.net
      
      wrote:
      
      On 19.12.2013 10:31, Teo Box wrote:
      
      Doh! I do !
      
      Attachment: xz-support.patch.gz (4.5 kB; application/x-gzip)
      
      Thank you very much. The patch appears to work.
      
      Happy Christmas!
      
      [patches:#12] http://sourceforge.net/p/xarchiver/patches/12/
      Cumulative patch + xz, tar.xz, rar5 (new version) support*
      
      Status: open
      Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
      Last Updated: Thu Dec 19, 2013 09:31 AM UTC
      Owner: Giuseppe Torelli
      
      Helo,
      I made a cumulative patch (including all previous patch I can find on the
      web)
      plus the full support of xz, tar.xz and rar5 archive format coded by me.
      
      please read 'note.txt' before compilling.
      
      My two cents.
      Teo
      
      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/xarchiver/patches/12/
      
      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/
      
      [patches:#12] Cumulative patch + xz, tar.xz, rar5 (new version)
      support
      
      Status: open
      Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
      Last Updated: Thu Dec 19, 2013 09:31 AM UTC
      Owner: Giuseppe Torelli
      
      Helo,
      I made a cumulative patch (including all previous patch I can find on the
      web)
      plus the full support of xz, tar.xz and rar5 archive format coded by me.
      
      please read 'note.txt' before compilling.
      
      My two cents.
      Teo
      
      Sent from sourceforge.net because you indicated interest in <
      https://sourceforge.net/p/xarchiver/patches/12/>
      
      To unsubscribe from further messages, please visit <
      https://sourceforge.net/auth/subscriptions/>
      
      Related
      
      Patches: #12
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-21

Hi Giuseppe,
now I've finish to work on 0.5.2, and for me this version is pretty stable.
I can start working on 6.0, now, I reviewing the code, I think I can produce some archiver plugins soon.

I keep in touch.
Teo

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Giuseppe Torelli - 2013-12-21
  
  A M A Z I N G.
  
  Thank you.
  Giuseppe
  On 21 Dec 2013 12:39, "Teo Box" tbox1@users.sf.net wrote:
  
  Hi Giuseppe,
  now I've finish to work on 0.5.2, and for me this version is pretty stable.
  I can start working on 6.0, now, I reviewing the code, I think I can
  produce some archiver plugins soon.
  
  I keep in touch.
  Teo
  
  [patches:#12] Cumulative patch + xz, tar.xz, rar5 (new version)
  support
  
  Status: open
  Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
  Last Updated: Thu Dec 19, 2013 09:31 AM UTC
  Owner: Giuseppe Torelli
  
  Helo,
  I made a cumulative patch (including all previous patch I can find on the
  web)
  plus the full support of xz, tar.xz and rar5 archive format coded by me.
  
  please read 'note.txt' before compilling.
  
  My two cents.
  Teo
  
  Sent from sourceforge.net because you indicated interest in <
  https://sourceforge.net/p/xarchiver/patches/12/>
  
  To unsubscribe from further messages, please visit <
  https://sourceforge.net/auth/subscriptions/>
  
  Related
  
  Patches: #12
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-21

For Markus,

Please find below, my others patch (splitted in small patch), that apply against your git.

there is a note.txt, that explain what is fixed/patched with test case

apply in this order:

rpm2cpio.patch
fix-multiextract.patch
xz-support.patch
test-support.patch
fix-unrar-can-add.patch
fix-icon-update.patch

with theses fix, we have all the same version !

only miss the RAR5 support (and the extened RAR support)

once the patchs above was commited, I'll make last one for RAR5.

Best regards
Teo

Last edit: Teo Box 2013-12-21

update-patch.tar.gz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Giuseppe Torelli - 2013-12-21
  
  Are we going to have two different 0.5.2 then?
  
  Marcus: 8'm going to release 0.5.3 with the patches of Teo.
  
  Teo: does your patch include your name in the gtk about dialog?
  
  Giuseppe
  On 21 Dec 2013 13:10, "Teo Box" tbox1@users.sf.net wrote:
  
  For Markus,
  
  Please find below, my others patch (splitted in small patch), that apply
  against your git.
  
  there is a note.txt, that explain what is fixed/patched with test case
  
  Best regards
  Teo
  
  Attachment: updated_patch.tar.gz (9.3 kB; application/download)
  
  [patches:#12] Cumulative patch + xz, tar.xz, rar5 (new version)
  support
  
  Status: open
  Created: Fri Dec 06, 2013 10:38 AM UTC by Teo Box
  Last Updated: Sat Dec 21, 2013 12:39 PM UTC
  Owner: Giuseppe Torelli
  
  Helo,
  I made a cumulative patch (including all previous patch I can find on the
  web)
  plus the full support of xz, tar.xz and rar5 archive format coded by me.
  
  please read 'note.txt' before compilling.
  
  My two cents.
  Teo
  
  Sent from sourceforge.net because you indicated interest in <
  https://sourceforge.net/p/xarchiver/patches/12/>
  
  To unsubscribe from further messages, please visit <
  https://sourceforge.net/auth/subscriptions/>
  
  Related
  
  Patches: #12
  
  alternate
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Markus Koschany - 2013-12-21
    
    On 21.12.2013 14:42, Giuseppe Torelli wrote:
    
    Are we going to have two different 0.5.2 then?
    
    Marcus: 8'm going to release 0.5.3 with the patches of Teo.
    ------------------------------------------------------------------------
    
    Yes, a new 0.5.3 release with all patches would be great. We only need
    one version and fixing everything upstream here at sourceforge is
    definitely the preferred way.
    
    The former Debian maintainer of Xarchiver checked out a different
    version from the old xfce.org subversion repository, so Debian's version
    differs slightly from 0.5.2 on this site.
    
    I'd really appreciate it if all Debian patches and Teo's great work
    could be incorporated in the next release, so that everyone benefits
    from it.
    
    http://patch-tracker.debian.org/package/xarchiver/1:0.5.2+20130119+dfsg-3
    
    signature.asc
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-21

Actually there is a litle difference between the last jumobo patch and patch for Markus,

missing :
- rpm2cpio
- rar5 support
- minor change

pending
- Full XZ, TAR.XZ support (seem to be ok)
- Full Test/Verify support
- fix-icon-update
- fix-multiextract
- fix-unrar-can-add

Because I start to work with the vanillia 0.5.2.tar.gz before I meet the Markus's git repository !

Markus, here the patch for rpm2cpio https://sourceforge.net/p/xarchiver/patches/6/

yep, my name is in about dialogue.
Teo

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Teo Box - 2013-12-21

Post updated
https://sourceforge.net/p/xarchiver/patches/12/?limit=10&page=2#a5f5

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cumulative patch + xz, tar.xz, rar5 (new version) support

Group

Searches

Help

#12 Cumulative patch + xz, tar.xz, rar5 (new version) support

Related

Discussion

Related

Related

Happy Christmas!

Related

Happy Christmas!

Related

Related

Related