Menu

#8 Window.setInterval implementation

closed-accepted
None
5
2008-03-23
2008-03-17
No

The HTML Renderer component has no implementation of the setInterval method in window interface.
Here is a specification of that method (thx mozilla.org) :
http://developer.mozilla.org/en/docs/DOM:window.setInterval

In order do implement that method, I found a way by re-using the setTimeout implementation.

The attach file is a patch that describe how to implement this method, how to improve in the future and what is to do one day.

It does not implement the clearInterval method (http://developer.mozilla.org/en/docs/DOM:window.clearInterval) but if I have time and needs ...

Best regards,
Guillaume W.

Discussion

  • Lobo Project Lead

    • assigned_to: nobody --> lobochief
     
  • Guillaume Wallet

     
  • Guillaume Wallet

    Logged In: YES
    user_id=1731318
    Originator: YES

    I terminate the full implementation of setInterval(Function, int) et setInterval(String, int)
    I add the implementation of clearInterval(int)

    The details are in the diff.

    Rgds,
    Guillaume WALLET

    File Added: patch-gwallet-Window-xxxInterval.diff

     
  • Lobo Project Lead

    Logged In: YES
    user_id=1837185
    Originator: NO

    Looks good. I've accepted it into the mainline codebase. The patch should appear in version 0.98.1.

    I couldn't apply it as a patch, since it was just a diff, but what needed to be done was straightforward in this particular case. There is a way to produce a patch file with CVS, which is substantially easier to apply.

    Thanks again for the patch.

     
  • Lobo Project Lead

    • status: open --> closed-accepted
     

Log in to post a comment.