[wxperl-users] [ wxperl-Patches-1316490 ] Wx::ControlWithItems::Append Return Value

[SourceForge.net <no...@so...>]

Patches item #1316490, was opened at 2005-10-07 15:42
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=315655&aid=1316490&group_id=15655

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: John Ralls (jralls)
Assigned to: Nobody/Anonymous (nobody)
Summary: Wx::ControlWithItems::Append Return Value

Initial Comment:
Currently, Wx::ControlWithItems returns void. This is wrong, it's 
supposed to return int (the index of the new item). Fortunately, this is 
easily fixed:

--- Controls.xs.~1.35.~ 2005-01-04 09:14:34.000000000 -0800
+++ Controls.xs 2005-10-07 15:31:35.000000000 -0700
@@ -50,7 +50,7 @@
 
 MODULE=Wx_Ctrl PACKAGE=Wx::ControlWithItems
 
-void
+int
 wxControlWithItems::Append( ... )
   PPCODE:
     BEGIN_OVERLOAD()
@@ -58,18 +58,22 @@
         MATCH_REDISP( wxPliOvl_s, AppendString )
     END_OVERLOAD( Wx::ControlWithItems::Append )
 
-void
+int
 wxControlWithItems::AppendString( item )
     wxString item
   CODE:
-    THIS->Append( item );
+    RETVAL = THIS->Append( item );
+  OUTPUT:         
+    RETVAL
 
-void
+int
 wxControlWithItems::AppendData( item, data )
     wxString item
     wxPliUserDataCD* data
   CODE:
-    THIS->Append( item, data );
+    RETVAL = THIS->Append( item, data );
+  OUTPUT:
+    RETVAL
 
 void
 wxControlWithItems::Delete( n )


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=315655&aid=1316490&group_id=15655