From: John L. <jla...@gm...> - 2006-03-03 17:10:34
|
Currently we have a *.cpp for each *.i file and then wx_builtin.cpp wx_class.cpp wx_define.cpp wx_event.cpp wx_object.cpp total: ~200K for all of wxWidgets for each of the different types of bindings. I think it would make sense to combine all of these together. Originally wxLua just had a single 2MB binding file, which was just too large, but by separating out the .i file code the rest of the glue code is pretty small. It'll make it easier to understand what's what too. After the change we'll have *.i -> *.cpp for the binding code itself a single header the glue code file Any objections? If not then I'll get to this on the weekend. Regards, John Labenski |
From: Francesco M. <f18...@ya...> - 2006-03-03 18:30:37
|
John Labenski ha scritto: > Currently we have a *.cpp for each *.i file and then > > wx_builtin.cpp > wx_class.cpp > wx_define.cpp > wx_event.cpp > wx_object.cpp > total: ~200K for all of wxWidgets > > for each of the different types of bindings. I think it would make > sense to combine all of these together. Originally wxLua just had a > single 2MB binding file, which was just too large, but by separating > out the .i file code the rest of the glue code is pretty small. It'll > make it easier to understand what's what too. > > After the change we'll have > *.i -> *.cpp for the binding code itself > a single header > the glue code file > > Any objections? If not then I'll get to this on the weekend. I think it's a good idea since many of these wx_*.cpp are very little; merging them should just make wxLua look cleaner ;) Francesco |
From: klaas.holwerda <kho...@xs...> - 2006-03-03 20:18:30
|
John Labenski wrote: > Any objections? If not then I'll get to this on the weekend. > Nop, at least i don't see a problem, the main issue was always compiling time, i think this was solved. Klaas |
From: John L. <jla...@gm...> - 2006-03-03 23:33:00
|
On 3/3/06, klaas.holwerda <kho...@xs...> wrote: > John Labenski wrote: > > Any objections? If not then I'll get to this on the weekend. > > > Nop, at least i don't see a problem, the main issue was always > compiling time, i think this was solved. Ok, all done. Francesco, since I'm still having problems with bakefile, could you remove the files below and rebake them. It looks like you're using *.cpp to find the files, so I haven't touched the bakefiles. As a stopgap until the bakefiles are redone I've just emptied the old files and made XXX_class.cpp have #include "wx_bind.cpp" so it should still work. modules/wxbind/src/ -- they're all empty wx_builtin.cpp wx_class.cpp wx_define.cpp wx_event.cpp wx_object.cpp modules/wxbindstc/src/ -- they're all empty wxstc_builtin.cpp wxstc_class.cpp wxstc_define.cpp wxstc_event.cpp wxstc_object.cpp apps/wxluacan/src/ -- they're all empty wxluacan_builtin.cpp wxluacan_class.cpp wxluacan_define.cpp wxluacan_event.cpp wxluacan_object.cpp Thanks, let me know if everything still works. John Labenski |
From: Francesco M. <f18...@ya...> - 2006-03-04 07:50:29
|
Hi, John Labenski ha scritto: > On 3/3/06, klaas.holwerda <kho...@xs...> wrote: >> John Labenski wrote: >>> Any objections? If not then I'll get to this on the weekend. >>> >> Nop, at least i don't see a problem, the main issue was always >> compiling time, i think this was solved. > > Ok, all done. Francesco, since I'm still having problems with > bakefile, could you remove the files below and rebake them. It looks > like you're using *.cpp to find the files, so I haven't touched the > bakefiles. > > As a stopgap until the bakefiles are redone I've just emptied the old > files and made XXX_class.cpp have #include "wx_bind.cpp" so it should > still work. > > modules/wxbind/src/ -- they're all empty > wx_builtin.cpp > wx_class.cpp > wx_define.cpp > wx_event.cpp > wx_object.cpp > > modules/wxbindstc/src/ -- they're all empty > wxstc_builtin.cpp > wxstc_class.cpp > wxstc_define.cpp > wxstc_event.cpp > wxstc_object.cpp > > apps/wxluacan/src/ -- they're all empty > wxluacan_builtin.cpp > wxluacan_class.cpp > wxluacan_define.cpp > wxluacan_event.cpp > wxluacan_object.cpp > > Thanks, let me know if everything still works. Done and committed the changes in build system. Everything still works on my Linux - need to check on windows but it should really work there too. Francesco |