Thread: [Wxlua-users] Why wxluasetup.h.in and wxluasetup.h ?

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Hi,
    why do we have both:
modules/wxbind/src/wxluasetup.h
bindings/wxwidgets/wxluasetup.h.in

is the last one something old which should be removed ?

Thanks,
Francesco

On 2/2/06, Francesco Montorsi <f18...@ya...> wrote:
> Hi,
>     why do we have both:
> modules/wxbind/src/wxluasetup.h
> bindings/wxwidgets/wxluasetup.h.in
>
> is the last one something old which should be removed ?

bindings/wxwidgets/wxluasetup.h.in

is supposed to be a base version of wxluasetup.h that people can start
from, I guess it can be removed when you move

modules/wxbind/src/wxluasetup.h
to
modules/setup/wxluasetup.h

I removed the #include "bindings/wxwidgets/wxluasetup.h.in" in
modules/wxlua/src/internal.cpp. I guess it's not necessary anymore or
it was just left over from before.

Regards,
    John Labenski

Hi,

John Labenski ha scritto:
> On 2/2/06, Francesco Montorsi <f18...@ya...> wrote:
>> Hi,
>>     why do we have both:
>> modules/wxbind/src/wxluasetup.h
>> bindings/wxwidgets/wxluasetup.h.in
>>
>> is the last one something old which should be removed ?
> 
> bindings/wxwidgets/wxluasetup.h.in
> 
> is supposed to be a base version of wxluasetup.h that people can start
> from, I guess it can be removed when you move
> 
> modules/wxbind/src/wxluasetup.h
> to
> modules/setup/wxluasetup.h
> 
> I removed the #include "bindings/wxwidgets/wxluasetup.h.in" in
> modules/wxlua/src/internal.cpp. I guess it's not necessary anymore or
> it was just left over from before.
Thanks for the changes.
Currently I implemented what we discussed about the WXLUASETUP_DIR and 
WXLUABINDLIB_DIR options creating a new bakefile in

modules/wxbind/build

so I thought that it was a 'cleaner' idea to put wxluasetup.h in

modules/wxbind/setup

instead of modules/setup. After all, wxluasetup.h is a setup for wxbind, 
right ?

I still need to test the makefiles in modules/wxbind/build; they are 
just a first rough draft. I'll work on them tomorrow.

Francesco

Hi,

Francesco Montorsi wrote:

>>
>> to
>> modules/setup/wxluasetup.h
>>
>> I removed the #include "bindings/wxwidgets/wxluasetup.h.in" in
>> modules/wxlua/src/internal.cpp. I guess it's not necessary anymore or
>> it was just left over from before.
>
>
>
> so I thought that it was a 'cleaner' idea to put wxluasetup.h in
>
> modules/wxbind/setup
>
> instead of modules/setup. After all, wxluasetup.h is a setup for 
> wxbind, right ?

But that is putting it in a module. While there are already two binding 
modules.
I am not sure it they use the same wxluasetup.h, but if yes i would say 
it has to be in:

modules/setup

Currently i see a wxluasetup.h in wxbindstc/src  too.

or in a new include dir in:

modules/bindings/include

I can imagine that this file can be used module broad for more then 
setting bindings on/off.

Klaas

-- 
Unclassified

> > so I thought that it was a 'cleaner' idea to put wxluasetup.h in
> >
> > modules/wxbind/setup
> >
> > instead of modules/setup. After all, wxluasetup.h is a setup for
> > wxbind, right ?
>
> But that is putting it in a module. While there are already two binding
> modules.
> I am not sure it they use the same wxluasetup.h, but if yes i would say
> it has to be in:
>
> modules/setup
>
> Currently i see a wxluasetup.h in wxbindstc/src  too.
>
> or in a new include dir in:
>
> modules/bindings/include
>
> I can imagine that this file can be used module broad for more then
> setting bindings on/off.

That's where it gets a little tricky. The wxSTC binding also depends
on the wxLUA_USE stuff, for example wxPoint, wxColour, wxWindow, etc,
but I really don't want to have to go nuts and cross link all the
dependencies since it'll make things very complicated.

I suppose the best solution is to use the wxSTC bindings without any
wxluasetup.h file and in a doc file just state the things that have to
be turned on to make it work. It should be pretty obvious to people
that if they want a complicated widget like wxSTC they have to bind to
a large portion of wxWidgets.

Regards,
    John Labenski

But still when wxbindstc also depends on

wxluasetup.h

better use one wxluasetup.h in:

modules/setup

which both bindings modules do use.

This is actually what i saw today in apps.bkl ??

        <!-- always use wxLua's official wxluasetup.h -->
        <include>$(WXLUA_BASEDIR)/modules/setup</include>

Klaas

John Labenski wrote:

>>>so I thought that it was a 'cleaner' idea to put wxluasetup.h in
>>>
>>>modules/wxbind/setup
>>>
>>>instead of modules/setup. After all, wxluasetup.h is a setup for
>>>wxbind, right ?
>>>      
>>>
>>But that is putting it in a module. While there are already two binding
>>modules.
>>I am not sure it they use the same wxluasetup.h, but if yes i would say
>>it has to be in:
>>
>>modules/setup
>>
>>Currently i see a wxluasetup.h in wxbindstc/src  too.
>>
>>or in a new include dir in:
>>
>>modules/bindings/include
>>
>>I can imagine that this file can be used module broad for more then
>>setting bindings on/off.
>>    
>>
>
>That's where it gets a little tricky. The wxSTC binding also depends
>on the wxLUA_USE stuff, for example wxPoint, wxColour, wxWindow, etc,
>but I really don't want to have to go nuts and cross link all the
>dependencies since it'll make things very complicated.
>
>I suppose the best solution is to use the wxSTC bindings without any
>wxluasetup.h file and in a doc file just state the things that have to
>be turned on to make it work. It should be pretty obvious to people
>that if they want a complicated widget like wxSTC they have to bind to
>a large portion of wxWidgets.
>
>
>  
>

-- 
Unclassified

On 2/3/06, k. holwerda <kla...@nl...> wrote:
> But still when wxbindstc also depends on
> wxluasetup.h
> better use one wxluasetup.h in:
> modules/setup
> which both bindings modules do use.

As I said, this should not be a requirement for the wxstc binding. The
#include "wxluasetup.h" is hardcoded into the genwxbind.lua generator.
It can easily be removed and I will do that now.

> This is actually what i saw today in apps.bkl ??
>
>         <!-- always use wxLua's official wxluasetup.h -->
>         <include>$(WXLUA_BASEDIR)/modules/setup</include>

These just follow the C++ code to make it compile, this is probably a typo.

-John

Hi,

John Labenski ha scritto:
>> This is actually what i saw today in apps.bkl ??
>>
>>         <!-- always use wxLua's official wxluasetup.h -->
>>         <include>$(WXLUA_BASEDIR)/modules/setup</include>
> 
> These just follow the C++ code to make it compile, this is probably a typo.
Yes; it was a typo.
Now it's fixed.

Francesco

Hi,

John Labenski ha scritto:
>>> so I thought that it was a 'cleaner' idea to put wxluasetup.h in
>>>
>>> modules/wxbind/setup
>>>
>>> instead of modules/setup. After all, wxluasetup.h is a setup for
>>> wxbind, right ?
>> But that is putting it in a module. While there are already two binding
>> modules.
>> I am not sure it they use the same wxluasetup.h, but if yes i would say
>> it has to be in:
>>
>> modules/setup
>>
>> Currently i see a wxluasetup.h in wxbindstc/src  too.
>>
>> or in a new include dir in:
>>
>> modules/bindings/include
>>
>> I can imagine that this file can be used module broad for more then
>> setting bindings on/off.
> 
> That's where it gets a little tricky. The wxSTC binding also depends
> on the wxLUA_USE stuff, for example wxPoint, wxColour, wxWindow, etc,
> but I really don't want to have to go nuts and cross link all the
> dependencies since it'll make things very complicated.
> 
> I suppose the best solution is to use the wxSTC bindings without any
> wxluasetup.h file and in a doc file just state the things that have to
> be turned on to make it work. It should be pretty obvious to people
> that if they want a complicated widget like wxSTC they have to bind to
> a large portion of wxWidgets.
even better, I think that a set of blocks like:

#if !wxLUA_USE_REQUIREDFEATURE
	#error Cannot build wxSTC bindings with wxLUA_USE_REQUIREDFEATURE = 0 !
#endif

could be very useful...

Francesco

PS: BTW on my local copy I see now two wxluasetup.h; one in 
modules/wxbind/setup and one in modules/wxbindstc/src.
If I understood correctly, the last one can be removed, right ?

What about the first one ? John, do you agree with Klaas that it should 
be moved one level up (in modules/setup) ?

On 2/3/06, Francesco Montorsi <f18...@ya...> wrote:
> Hi,
>
> John Labenski ha scritto:
> >>> so I thought that it was a 'cleaner' idea to put wxluasetup.h in
> >>>
> >>> modules/wxbind/setup
> >>>
> >>> instead of modules/setup. After all, wxluasetup.h is a setup for
> >>> wxbind, right ?
> >> But that is putting it in a module. While there are already two bindin=
g
> >> modules.
> >> I am not sure it they use the same wxluasetup.h, but if yes i would sa=
y
> >> it has to be in:
> >>
> >> modules/setup
> >>
> >> Currently i see a wxluasetup.h in wxbindstc/src  too.
> >>
> >> or in a new include dir in:
> >>
> >> modules/bindings/include
> >>
> >> I can imagine that this file can be used module broad for more then
> >> setting bindings on/off.
> >
> > That's where it gets a little tricky. The wxSTC binding also depends
> > on the wxLUA_USE stuff, for example wxPoint, wxColour, wxWindow, etc,
> > but I really don't want to have to go nuts and cross link all the
> > dependencies since it'll make things very complicated.
> >
> > I suppose the best solution is to use the wxSTC bindings without any
> > wxluasetup.h file and in a doc file just state the things that have to
> > be turned on to make it work. It should be pretty obvious to people
> > that if they want a complicated widget like wxSTC they have to bind to
> > a large portion of wxWidgets.
> even better, I think that a set of blocks like:
>
> #if !wxLUA_USE_REQUIREDFEATURE
>         #error Cannot build wxSTC bindings with wxLUA_USE_REQUIREDFEATURE=
 =3D 0 !
> #endif
>
> could be very useful...

Could be a pain in the ass to maintain too. :)  Remember that if you
do this then the wxSTC binding has to find the wxluasetup.h file that
was used for the wxWidgets bindings. I don't think that people will
have a hard time understanding that if they want to use wxSTC they've
got to include the classes it depends on.

> PS: BTW on my local copy I see now two wxluasetup.h; one in
> modules/wxbind/setup and one in modules/wxbindstc/src.
> If I understood correctly, the last one can be removed, right ?

Not yet, the bindings have to be rewritten to not use it.

> What about the first one ? John, do you agree with Klaas that it should
> be moved one level up (in modules/setup) ?

Ehhhh, I think it's not a general wxLua setup file, but rather that
it's just for the wxWidgets bindings. I like your idea of putting it
in wxbind/setup. If there are ever any other bindings, they may have
their own setup files. I'd leave it where it is.

-John

Thread: [Wxlua-users] Why wxluasetup.h.in and wxluasetup.h ?

wxlua-users