|
From: klaas.holwerda <kho...@xs...> - 2006-12-11 22:33:20
|
Francesco Montorsi wrote: > Klaas Holwerda ha scritto: > >> All in all i think i still like this a little more: >> >> wxlua_msw28d_debug.lib >> >> compared to: >> >> wxmsw28d_wxlua_debug.lib >> >> The namespace in the beginning is easier when it comes to sorting (ls or dir will show them grouped ). >> > I agree, I like to see "wxlua" as a prefix instead of having it in the middle. > > > >>>> ps. The precompiled headers are GREAT! I can't really tell much of a >>>> >>> difference in MSVC6, but I was thinking about how we could do it and >>> wanted to ask if you knew how, but thought it might be too much work. >>> >> Well in wxArt2D we have it working. The idea is this: >> >> // our own pre compiled header file. >> #include "general/include/a2dprec.h" >> >> #ifdef __GNUG__ >> #pragma implementation "artglob.h" >> #endif >> >> #ifdef __BORLANDC__ >> #pragma hdrstop >> #endif >> >> #ifndef WX_PRECOMP >> #include "wx/wx.h" >> #endif >> >> > well, I'd say that we should infact have a wxluaprec.h file sure. I think you mean that in my case #include "wxart2d.h" is not really needed inside the #include "general/include/a2dprec.h"? But i use it for other cases when no PCH is in question. > and then put all > possible headers there and all other unnecessary #include directives into the > WX_PRECOMP block. > > I think we should also remove these blocks: > > #if defined(__GNUG__) && !defined(NO_GCC_PRAGMA) > #pragma implementation "wxlstate.h" > #endif > > GCC does not use it anymore since a long time and they can only give problems... > Very right, i still needed to that. Klaas |